All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mauro Carvalho Chehab <mchehab@redhat.com>
To: Kang Yong <kangyong@telegent.com>, Zhang Xiaobing <xbzhang@telegent.com>
Cc: Linux Media Mailing List <linux-media@vger.kernel.org>
Subject: BKL removal from tlg2300 driver
Date: Sun, 19 Sep 2010 10:30:55 -0300	[thread overview]
Message-ID: <4C96108F.3070708@redhat.com> (raw)

Kang/Zhang,

BKL will be removed from kernel soon. This means that all calls to lock_kernel/unlock_kernel
should be replaced by some other locking schema, and that the .ioctl callback should be
replaced by .unlocked_ioctl.

We're converting the existing drivers in order to avoid BKL usage. 

Unfortunately, I don't have any tlg2300 hardware for testing, and it uses lock_kernel() 
on a different way than the other drivers. I suspect that all that all it needs is to properly
use the new locking schema we're adopting at v4l2 core, just like the conversion we did for
em28xx:

http://git.linuxtv.org/media_tree.git?a=commitdiff;h=b59117ed27706bf6059eeabf2698d1d33e2e67d0

Could you please review it and send me a patch?

Thanks,
Mauro

                 reply	other threads:[~2010-09-19 13:31 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C96108F.3070708@redhat.com \
    --to=mchehab@redhat.com \
    --cc=kangyong@telegent.com \
    --cc=linux-media@vger.kernel.org \
    --cc=xbzhang@telegent.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.