From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=47681 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Oxdux-0004ZF-69 for qemu-devel@nongnu.org; Mon, 20 Sep 2010 06:48:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1Oxdus-0002jv-Fp for qemu-devel@nongnu.org; Mon, 20 Sep 2010 06:48:15 -0400 Received: from mx1.redhat.com ([209.132.183.28]:29448) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Oxdus-0002jc-5c for qemu-devel@nongnu.org; Mon, 20 Sep 2010 06:48:10 -0400 Received: from int-mx03.intmail.prod.int.phx2.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o8KAm8Xa010355 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 20 Sep 2010 06:48:08 -0400 Message-ID: <4C973C12.7050905@redhat.com> Date: Mon, 20 Sep 2010 12:48:50 +0200 From: Michal Novotny MIME-Version: 1.0 References: <4C972DCF.1050003@redhat.com> <4C9738B4.4010809@redhat.com> In-Reply-To: <4C9738B4.4010809@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH] Make NIC model fallback to default when specified model is not supported List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: qemu-devel On 09/20/2010 12:34 PM, Paolo Bonzini wrote: > On 09/20/2010 11:47 AM, Michal Novotny wrote: >> Hi, >> >> this is the patch to introduce a NIC model fallback to default when >> model >> specified is not supported. It's been tested on i386-softmmu target on >> i386 host using the Windows XP x86 virtual machine and by trying to >> setup >> the invalid (unsupported) model of NIC device. Also, the new constant in >> the net.h called the DEFAULT_NIC_MODEL has been introduced to be able to >> change the default NIC model easily. This variable is being used to set >> the default NIC model when necessary. > > Why? If it's not supported, it shouldn't run. > > Paolo I don't think so. It makes sense it shouldn't run for case of pure qemu but since there's newly added support for xen (and also there's support for other virtualization platforms to be used with the qemu device model) it should fallback with just a warning since otherwise those platforms, like e.g. mentioned Xen, will leave defunct device models there and the guests won't run be running at all ending up with no state. If there's a warning with information it's falling back to default the user can notice if he wants to but it won't leave the defunct device models anymore which can be pretty hard to determine what's going on there for standard user that doesn't have much experience with e.g. Xen yet. Michal -- Michal Novotny, RHCE Virtualization Team (xen userspace), Red Hat