All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rik van Riel <riel@redhat.com>
To: Minchan Kim <minchan.kim@gmail.com>
Cc: caiqian@redhat.com, linux-mm <linux-mm@kvack.org>,
	KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
	"M. Vefa Bicakci" <bicave@superonline.com>,
	Johannes Weiner <hannes@cmpxchg.org>,
	stable@kernel.org, akpm@linux-foundation.org
Subject: Re: cgroup oom regression introduced by 6a5ce1b94e1e5979f8db579f77d6e08a5f44c13b
Date: Mon, 20 Sep 2010 09:13:37 -0400	[thread overview]
Message-ID: <4C975E01.3070503@redhat.com> (raw)
In-Reply-To: <20100918152120.GA21343@barrios-desktop>

On 09/18/2010 11:21 AM, Minchan Kim wrote:

> When memory pressure in memcg is high, do_try_to_free_pages returns
> 0. It causes mem_cgroup_out_of_memory so that any process in mem group
> would be killed.
> But vmscan-check-all_unreclaimable-in-direct-reclaim-path.patch changed
> the old behavior. It returns 1 unconditionally regardless of considering
> global reclaim or memcg relcaim. It causes hang without triggering OOM
> in case of memcg direct reclaim.
>
> This patch fixes it.
>
> It's reported by caiqian@redhat.com.
> (Thanks. Totally, it's my fault.)
>
> Reported-by: caiqian@redhat.com
> Cc: KOSAKI Motohiro<kosaki.motohiro@jp.fujitsu.com>
> Cc: Johannes Weiner<hannes@cmpxchg.org>
> Cc: Rik van Riel<riel@redhat.com>
> Cc: KAMEZAWA Hiroyuki<kamezawa.hiroyu@jp.fujitsu.com>
> Cc: Balbir Singh<balbir@in.ibm.com>
> Signed-off-by: Minchan Kim<minchan.kim@gmail.com>

Acked-by: Rik van Riel <riel@redhat.com>


-- 
All rights reversed

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  parent reply	other threads:[~2010-09-20 13:14 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1296415999.1298271284814035815.JavaMail.root@zmail06.collab.prod.int.phx2.redhat.com>
2010-09-18 12:52 ` cgroup oom regression introduced by 6a5ce1b94e1e5979f8db579f77d6e08a5f44c13b caiqian
2010-09-18 15:21   ` Minchan Kim
2010-09-20  8:01     ` CAI Qian
2010-09-20 13:13     ` Rik van Riel [this message]
2010-09-21  0:06     ` KAMEZAWA Hiroyuki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C975E01.3070503@redhat.com \
    --to=riel@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=bicave@superonline.com \
    --cc=caiqian@redhat.com \
    --cc=hannes@cmpxchg.org \
    --cc=kosaki.motohiro@jp.fujitsu.com \
    --cc=linux-mm@kvack.org \
    --cc=minchan.kim@gmail.com \
    --cc=stable@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.