From: Felix Fietkau <nbd@openwrt.org>
To: "Luis R. Rodriguez" <lrodriguez@atheros.com>
Cc: linux-wireless@vger.kernel.org, linville@tuxdriver.com
Subject: Re: [PATCH 2/5] ath9k: fix an aggregation start related race condition
Date: Mon, 20 Sep 2010 16:29:17 +0200 [thread overview]
Message-ID: <4C976FBD.8010007@openwrt.org> (raw)
In-Reply-To: <AANLkTinRQsy3JZ5yr_9xjPhFA3Mez5ewV1V+R1dN3yen@mail.gmail.com>
On 2010-09-20 4:19 PM, Luis R. Rodriguez wrote:
> On Mon, Sep 20, 2010 at 4:45 AM, Felix Fietkau <nbd@openwrt.org> wrote:
>> A new aggregation session start can be issued by mac80211, even when the
>> cleanup of the previous session has not completed yet. Since the data structure
>> for the session is not recreated, this could corrupt the block ack window
>> and lock up the aggregation session. Fix this by delaying the new session
>> until the old one has been cleaned up.
>>
>> Signed-off-by: Felix Fietkau <nbd@openwrt.org>
>> Cc: stable@kernel.org
>
> Any reason to not fix this in mac80211 instead?
mac80211 is already doing the right thing here. The cleanup is ath9k
specific.
- Felix
next prev parent reply other threads:[~2010-09-20 14:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-20 11:45 [PATCH 1/5] ath9k: clean up block ack window handling Felix Fietkau
2010-09-20 11:45 ` [PATCH 2/5] ath9k: fix an aggregation start related race condition Felix Fietkau
2010-09-20 11:45 ` [PATCH 3/5] ath9k: clean up / fix aggregation session flush Felix Fietkau
2010-09-20 11:45 ` [PATCH 4/5] ath9k: move ath_tx_aggr_check() to the rate control module Felix Fietkau
2010-09-20 11:45 ` [PATCH 5/5] ath9k: make the driver specific rate control module optional Felix Fietkau
2010-09-20 14:19 ` [PATCH 2/5] ath9k: fix an aggregation start related race condition Luis R. Rodriguez
2010-09-20 14:29 ` Felix Fietkau [this message]
2010-09-20 14:35 ` Luis R. Rodriguez
2010-09-20 17:35 ` [PATCH v2 " Felix Fietkau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C976FBD.8010007@openwrt.org \
--to=nbd@openwrt.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=lrodriguez@atheros.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.