From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=44863 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OxhT1-0002LR-QR
	for qemu-devel@nongnu.org; Mon, 20 Sep 2010 10:35:45 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <anthony@codemonkey.ws>) id 1OxhSq-0003h6-2l
	for qemu-devel@nongnu.org; Mon, 20 Sep 2010 10:35:32 -0400
Received: from mail-gx0-f173.google.com ([209.85.161.173]:46570)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <anthony@codemonkey.ws>) id 1OxhSp-0003h0-VR
	for qemu-devel@nongnu.org; Mon, 20 Sep 2010 10:35:28 -0400
Received: by gxk22 with SMTP id 22so1770573gxk.4
	for <qemu-devel@nongnu.org>; Mon, 20 Sep 2010 07:35:26 -0700 (PDT)
Message-ID: <4C977122.6010107@codemonkey.ws>
Date: Mon, 20 Sep 2010 09:35:14 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] Re: [PATCH] Make NIC model fallback to default when
	specified model is not supported
References: <4C972DCF.1050003@redhat.com>
	<4C9738B4.4010809@redhat.com>	<4C973C12.7050905@redhat.com>
	<20100920105341.GD18143@redhat.com>	<4C973FFD.9080904@redhat.com>
	<20100920110754.GE18143@redhat.com> <4C974240.4070208@redhat.com>
In-Reply-To: <4C974240.4070208@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Michal Novotny <minovotn@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel <qemu-devel@nongnu.org>

On 09/20/2010 06:15 AM, Michal Novotny wrote:
> Well, this way I guess we should have 2, maybe 3 different approaches 
> - different for qemu itself and for upstream version Xen using the 
> older version of qemu-dm and RHEL-5 version.
>
> Therefore I think we should drop the patch for qemu (the one sent to 
> this list) and decide about the others using their own lists/discussions.

BTW, the simple way to fix this in Xen is to launch qemu-dm -net 
nic,model=?, parse the output to determine if the requested nic is 
valid, then if it's not valid, print your warning to the user and then 
select a "default" nic.

No need to implement this logic in qemu-dm itself.

Regards,

Anthony Liguori

> Michal
>