From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=43901 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Oxl4L-0005TY-PB
	for qemu-devel@nongnu.org; Mon, 20 Sep 2010 14:26:26 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <anthony@codemonkey.ws>) id 1Oxl4G-0000Vz-In
	for qemu-devel@nongnu.org; Mon, 20 Sep 2010 14:26:25 -0400
Received: from mail-gy0-f173.google.com ([209.85.160.173]:51164)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <anthony@codemonkey.ws>) id 1Oxl4G-0000Vp-9l
	for qemu-devel@nongnu.org; Mon, 20 Sep 2010 14:26:20 -0400
Received: by gya1 with SMTP id 1so1858234gya.4
	for <qemu-devel@nongnu.org>; Mon, 20 Sep 2010 11:26:19 -0700 (PDT)
Message-ID: <4C97A73C.4070102@codemonkey.ws>
Date: Mon, 20 Sep 2010 13:26:04 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] Win2k host problem with {get,free}{addr,name}info()
References: <AANLkTi=2PE_cV1c=7xoUu95oYVuqTUCehxi2s0huivVU@mail.gmail.com>
	<4C911D8F.1060406@codemonkey.ws>
	<AANLkTi=R+AD1zWhh=0EOjqCJ1DrCJbohGadAdm9t2E3i@mail.gmail.com>
In-Reply-To: <AANLkTi=R+AD1zWhh=0EOjqCJ1DrCJbohGadAdm9t2E3i@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: qemu-devel <qemu-devel@nongnu.org>

On 09/19/2010 11:16 AM, Blue Swirl wrote:
> On Wed, Sep 15, 2010 at 7:25 PM, Anthony Liguori<anthony@codemonkey.ws>  wrote:
>    
>> On 09/15/2010 02:11 PM, Blue Swirl wrote:
>>      
>>> Hi,
>>>
>>> I tried to test QEMU on Win2k, but there are run time errors because
>>> of missing {get,free}{addr,name}info() functions. After adding dummy
>>> defines in place, there are no more errors.
>>>
>>> I found a similar case, where a compatibility patch was proposed:
>>> http://trac.filezilla-project.org/ticket/1532
>>>
>>> The patch is a bit heavy, consisting of run time detection of Win2k
>>> and full replacements for the functions. Are there any alternative
>>> solutions? I'm by no means a Windows expert.
>>>
>>>        
>> Win2k is EOL so I don't think it's useful for us to support it as a host.
>>   So any type of patch is just going to add additional complexity for very
>> little real gain.
>>      
> I made a compatibility patch based on the FileZilla patch. The impact
> is very low, outside of the new files added, only Makefiles are
> changed.
>    

Does gnulib have a similar replacement function?

The nice thing about gnulib is that in the long term, we could 
potentially use gnulib for compatibility and make sure to get updated code.

Regards,

Anthony Liguori

> With the patch I was able to run QEMU with network connectivity on
> Win2k. Also the tools work, they also seem to depend on getaddrinfo&
> co.
>
>   Makefile          |    6
>   Makefile.objs     |    3
>   Makefile.target   |    1
>   net/getaddrinfo.c |  413 ++++++++++++++++++++++++++++++++++++++++++++++++++++++
>   net/getaddrinfo.h |  121 +++++++++++++++
>   net/inet_ntop.c   |  237 ++++++++++++++++++++++++++++++
>   net/inet_ntop.h   |   47 ++++++
>   7 files changed, 825 insertions(+), 3 deletions(-)
>