From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Tokarev Subject: Re: [PATCH #upstream-fixes] ahci: fix module refcount breakage introduced by libahci split Date: Tue, 21 Sep 2010 11:32:24 +0400 Message-ID: <4C985F88.1010501@msgid.tls.msk.ru> References: <201009162256.04765.pedrogfrancisco@gmail.com> <47010.148.87.67.141.1284674336.squirrel@www.xenotime.net> <4C933A8F.2080305@gmail.com> <1284892106.2650.4.camel@sundae-v2> <4C9602E4.4090007@gmail.com> <1284974726.11757.9.camel@sundae-v2> <4C9729D7.70500@gmail.com> <4C972C60.8010506@gmail.com> <1285015465.26023.10.camel@sundae-v2> <4C97DB80.4060403@gmail.com> <4C97DBE2.8070707@gmail.com> <4C984D44.1080109@msgid.tls.msk.ru> <4C985DFC.7020203@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Return-path: Received: from isrv.corpit.ru ([86.62.121.231]:49805 "EHLO isrv.corpit.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753595Ab0IUHc0 (ORCPT ); Tue, 21 Sep 2010 03:32:26 -0400 In-Reply-To: <4C985DFC.7020203@gmail.com> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Tejun Heo Cc: Jeff Garzik , Pedro Francisco , linux-kernel@vger.kernel.org, "linux-ide@vger.kernel.org" 21.09.2010 11:25, Tejun Heo wrote: > libata depends on scsi_host_template for module reference counting and > sht's should be owned by each low level driver. During libahci split, > the sht was left with libahci.ko leaving the actual low level drivers > not reference counted. This made ahci and ahci_platform always > unloadable even while they're being actively used. > > Fix it by defining AHCI_SHT() macro in ahci.h and defining a sht for > each low level ahci driver. > > stable: only applicable to 2.6.35. > > Signed-off-by: Tejun Heo > Reported-by: Michael Tokarev > Cc: stable@kernel.org > --- > Michael, thanks a lot for spotting it and bearing with me. Um. All thanks goes to Pedro Francisco please, not to me - I just verified your patch on my system, it was Pedro who spotted and reported this. You may add my Tested-Off-By: Michael Tokarev , but not Reported-by... please ;) Thanks! /mjt