From: Kevin Wolf <kwolf@redhat.com>
To: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Cc: qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [PATCH] blkverify: Handle overlapping I/O vector buffers
Date: Tue, 21 Sep 2010 12:06:36 +0200 [thread overview]
Message-ID: <4C9883AC.2060308@redhat.com> (raw)
In-Reply-To: <1284989493-13154-1-git-send-email-stefanha@linux.vnet.ibm.com>
Am 20.09.2010 15:31, schrieb Stefan Hajnoczi:
> When blkverify clones an I/O vector in order to perform mirrored reads
> and then compare their contents, it does not take into account the
> layout of individual buffers. It turns out this is important because
> guests may issue requests with overlapping buffers and the results
> differ depending on how buffers are overlapped.
>
> This patch introduces logic to honor overlap relationships when cloning
> I/O vectors.
>
> Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Took me a while to review this. These buffer calculations always look so
harmless, but it's not trivial at all...
Anyway, looks good to me.
Kevin
next prev parent reply other threads:[~2010-09-21 10:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-20 13:31 [Qemu-devel] [PATCH] blkverify: Handle overlapping I/O vector buffers Stefan Hajnoczi
2010-09-21 10:06 ` Kevin Wolf [this message]
2010-09-21 10:43 ` [Qemu-devel] " Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C9883AC.2060308@redhat.com \
--to=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.