From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=36832 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Oy2BR-00085E-Md
	for qemu-devel@nongnu.org; Tue, 21 Sep 2010 08:43:03 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <anthony@codemonkey.ws>) id 1Oy2BJ-000803-N4
	for qemu-devel@nongnu.org; Tue, 21 Sep 2010 08:42:53 -0400
Received: from mail-gy0-f173.google.com ([209.85.160.173]:43783)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <anthony@codemonkey.ws>) id 1Oy2BJ-0007zo-Kf
	for qemu-devel@nongnu.org; Tue, 21 Sep 2010 08:42:45 -0400
Received: by gya1 with SMTP id 1so2148264gya.4
	for <qemu-devel@nongnu.org>; Tue, 21 Sep 2010 05:42:45 -0700 (PDT)
Message-ID: <4C98A82B.2010703@codemonkey.ws>
Date: Tue, 21 Sep 2010 07:42:19 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
References: <20100920182459.GE30611@redhat.com>
	<4C97AA44.8000403@codemonkey.ws>
	<20100920191500.GG30611@redhat.com>
	<4C97B5EA.9060809@codemonkey.ws>
	<20100920194415.GK30611@redhat.com>
	<4C97C22B.3010502@codemonkey.ws> <20100920202755.GA821@redhat.com>
	<4C97C64C.6010607@codemonkey.ws> <20100920203750.GC821@redhat.com>
	<4C97C92B.7000708@codemonkey.ws> <20100921091851.GC4365@redhat.com>
In-Reply-To: <20100921091851.GC4365@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH] net: delay peer host device delete
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: qemu-devel@nongnu.org

On 09/21/2010 04:18 AM, Michael S. Tsirkin wrote:
>> No, netdev_del should remove the VLANClientState from the
>> non_vlan_clients list.
>>
>> It's no longer enumerable and it's no longer lookup-able.
>>
>> The only reason it stays around it so that the device doesn't have a
>> reference to a free pointer.  The only field that's ever looked at
>> is is_deleted which is used by every function to turn around and
>> implement a nop.
>>
>> The VLANClientState is a hollow shell of it's former glorious self.
>> The remainder of it's (hopefully short) life is merely so that we
>> can avoid touching every device to teach them about disconnecting
>> backends.
>>      
> We'll have to tell them link is down, won't we?
>    

Yes, that would be a nice touch.

Regards,

Anthony Liguori