From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.cbnco.com ([207.164.182.72]) by linuxtogo.org with esmtp (Exim 4.69) (envelope-from ) id 1Oy5fE-0006X4-7F for openembedded-devel@lists.openembedded.org; Tue, 21 Sep 2010 18:25:58 +0200 Received: from localhost (localhost [127.0.0.1]) by smtp.cbnco.com (Postfix) with ESMTP id 423248A3C35 for ; Tue, 21 Sep 2010 12:25:42 -0400 (EDT) Received: from smtp.cbnco.com ([127.0.0.1]) by localhost (mail.cbnco.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 16148-06 for ; Tue, 21 Sep 2010 12:25:42 -0400 (EDT) Received: from [172.20.22.83] (auriga-dmzgw.cbnco.com [207.164.182.65]) by smtp.cbnco.com (Postfix) with ESMTPSA id 14BE36D7E29 for ; Tue, 21 Sep 2010 12:25:42 -0400 (EDT) Message-ID: <4C98DC85.30607@cbnco.com> Date: Tue, 21 Sep 2010 12:25:41 -0400 From: Michael Smith User-Agent: Thunderbird 2.0.0.24 (X11/20100228) MIME-Version: 1.0 To: openembedded-devel@lists.openembedded.org References: <4C97AC2B.1040205@cbnco.com> <4C98B9F0.2010005@cbnco.com> In-Reply-To: X-Virus-Scanned: amavisd-new at cbnco.com X-SA-Exim-Connect-IP: 207.164.182.72 X-SA-Exim-Mail-From: msmith@cbnco.com X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on discovery X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,SPF_HELO_PASS, SPF_PASS autolearn=ham version=3.2.5 X-SA-Exim-Version: 4.2.1 (built Wed, 25 Jun 2008 17:20:07 +0000) X-SA-Exim-Scanned: Yes (on linuxtogo.org) Subject: Re: [RFC] base.bbclass: add make-native to default dependencies X-BeenThere: openembedded-devel@lists.openembedded.org X-Mailman-Version: 2.1.11 Precedence: list Reply-To: openembedded-devel@lists.openembedded.org List-Id: Using the OpenEmbedded metadata to build Distributions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Sep 2010 16:25:58 -0000 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Khem Raj wrote: > On Tue, Sep 21, 2010 at 6:58 AM, Michael Smith wrote: >> Khem Raj wrote: >> >>> although it does but make 3.82 is not usable out of box yet. >>> so people might find surprises. 3.81 would be ok. > > I hit eglibc there may be more. Hmm, OK. The patch below wouldn't affect eglibc's dependencies, so we'd still have to change eglibc.inc and eglibc-initial.inc to depend on make-native, or people with make 3.82 on their host system will be unable to build eglibc. Or, apply a patch to every version of eglibc to fix the build with make 3.82. Which do you prefer? I can only really test glibc 2.9, but adding make-native to the DEPENDS in glibc.inc/glibc-initial.inc should work about the same as doing it in eglibc. Mike >>>> diff --git a/classes/base.bbclass b/classes/base.bbclass >>>> index b19eb32..5c6d41d 100644 >>>> --- a/classes/base.bbclass >>>> +++ b/classes/base.bbclass >>>> @@ -71,7 +71,7 @@ def base_deps(d): >>>> if not bb.data.getVar('INHIBIT_DEFAULT_DEPS', d): >>>> if (bb.data.getVar('HOST_SYS', d, 1) != >>>> bb.data.getVar('BUILD_SYS', d, 1)): >>>> - deps += " virtual/${TARGET_PREFIX}gcc >>>> virtual/libc " >>>> + deps += " make-native virtual/${TARGET_PREFIX}gcc >>>> virtual/libc " >>>> elif bb.data.inherits_class('native', d) and \ >>>> bb.data.getVar('PN', d, True) not in \ >>>> ("linux-libc-headers-native", >>>> "quilt-native",