From: Suraj Sumangala <suraj@Atheros.com>
To: Pavan Savoy <pavan_savoy@sify.com>
Cc: Suraj Sumangala <Suraj.Sumangala@Atheros.com>,
"linux-bluetooth@vger.kernel.org"
<linux-bluetooth@vger.kernel.org>,
Jothikumar Mothilal <Jothikumar.Mothilal@Atheros.com>
Subject: Re: [PATCH 2/2] Bluetooth: support to send power management enable during hci open
Date: Wed, 22 Sep 2010 09:31:16 +0530 [thread overview]
Message-ID: <4C997F8C.5070104@Atheros.com> (raw)
In-Reply-To: <AANLkTinS9YnKBUnv-RhV8ZZ185FtN_VDOWTQa3gTr6FC@mail.gmail.com>
Hi Pavan,
On 9/22/2010 1:22 AM, Pavan Savoy wrote:
> On Tue, Sep 21, 2010 at 8:33 AM, Suraj Sumangala<suraj@atheros.com> wrote:
>> This patch enables HCI_UART_ATH3K transport driver to support
>> sending Vendor specific hci commands during hci open
>> to enable or disable power management feature.
>
> Why? shouldn't this be done from the hciattach? like for the other
> manufacturers?
> If you want it to be sent before hci0 interface is exposed, send it
> over ttyXX, you have your _init function and if you require it to be
> sent after the hci0 is exposed - do it in the _post function.
>
We are already using the _init and _post of hciattach.
The mentioned feature will get disabled in the controller on receiving a
HCI RESET command.
If the user does an HCI close, this feature will be disabled and we need
to enable it again when the user opens the HCI device again.
I guess the "hdev->driver_init" queue is provided for that reason.
An hciattach is called only once but hci open/close can be done multiple
times.
Regards
Suraj
next prev parent reply other threads:[~2010-09-22 4:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-21 13:33 [PATCH 1/2] Bluetooth: hci open callback for hci UART transport driver Suraj Sumangala
2010-09-21 13:33 ` [PATCH 2/2] Bluetooth: support to send power management enable during hci open Suraj Sumangala
2010-09-21 19:52 ` Pavan Savoy
2010-09-22 4:01 ` Suraj Sumangala [this message]
2010-09-22 21:22 ` Pavan Savoy
2010-09-23 4:13 ` Suraj Sumangala
2010-09-30 8:31 ` [PATCH 1/2] Bluetooth: hci open callback for hci UART transport driver Suraj Sumangala
2010-10-04 17:29 ` Suraj Sumangala
2010-10-05 9:27 ` Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C997F8C.5070104@Atheros.com \
--to=suraj@atheros.com \
--cc=Jothikumar.Mothilal@Atheros.com \
--cc=Suraj.Sumangala@Atheros.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=pavan_savoy@sify.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.