All of lore.kernel.org
 help / color / mirror / Atom feed
From: "H. Peter Anvin" <hpa@zytor.com>
To: Bjorn Helgaas <bjorn.helgaas@hp.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	x86@kernel.org, Yinghai Lu <yinghai@kernel.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86: tidy e820 output
Date: Wed, 22 Sep 2010 11:27:59 -0700	[thread overview]
Message-ID: <4C9A4AAF.3030503@zytor.com> (raw)
In-Reply-To: <201009221220.34066.bjorn.helgaas@hp.com>

On 09/22/2010 11:20 AM, Bjorn Helgaas wrote:
> 
> These E820 ranges should be easily comparable with similar ranges we
> print elsewhere.  Currently we have things like this:
> 
>     BIOS-e820: 0000000000000000 - 000000000009f400 (usable)
>     BIOS-e820: 000000000009f400 - 00000000000a0000 (reserved)
>     BIOS-e820: 00000000fffbc000 - 0000000100000000 (reserved)
>     pci_root PNP0A03:00: host bridge window [mem 0x000a0000-0x000bffff]
>     pci_root PNP0A03:00: host bridge window [mem 0xe0000000-0xfebfffff]
>     pci 0000:00:02.0: reg 10: [mem 0xf0000000-0xf1ffffff pref]
>     reserve RAM buffer: 000000000009f400 - 000000000009ffff 
>     pnp 00:07: [mem 0xfed00000-0xfed003ff]
> 
> It would be easier to integrate the E820 information with the ACPI
> and PCI window and BAR information if they looked similar.
> 
> We currently have a mix of some with "0x" prefix, some without;
> some with eight hex digits, some with sixteen; some with spaces
> around the internal "-", some without; some with type (io/mem/etc),
> some without; some with uppercase hex (MTRR), most with lowercase;
> some including the end address, some not; and even some in PFNs
> and most in addresses.  It just makes it harder than it needs
> to be to debug issues in this area.
> 

Yes, but I think you can also see why I really don't like the thought of
the numbers in the BIOS-e820: block not even lining up anymore.

	-hpa


  reply	other threads:[~2010-09-22 18:28 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-22 17:27 [PATCH] x86: tidy e820 output Bjorn Helgaas
2010-09-22 17:54 ` H. Peter Anvin
2010-09-22 18:20   ` Bjorn Helgaas
2010-09-22 18:27     ` H. Peter Anvin [this message]
2010-09-22 18:53       ` Bjorn Helgaas
2010-09-22 18:58         ` H. Peter Anvin
2010-09-22 19:11           ` Bjorn Helgaas
2010-09-22 21:07             ` Yinghai Lu
2010-09-22 21:22               ` Bjorn Helgaas
2010-09-22 21:29                 ` Yinghai Lu
2010-09-22 21:34                 ` H. Peter Anvin
2010-09-22 22:05                   ` Bjorn Helgaas
2010-09-22 22:07                     ` H. Peter Anvin
2010-09-22 22:46           ` David Rientjes
2010-09-22 22:50             ` H. Peter Anvin
2010-09-22 23:12               ` David Rientjes
2010-09-22 23:16                 ` H. Peter Anvin
2010-09-22 23:27                   ` David Rientjes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C9A4AAF.3030503@zytor.com \
    --to=hpa@zytor.com \
    --cc=bjorn.helgaas@hp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    --cc=yinghai@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.