From: Mike Christie <michaelc@cs.wisc.edu>
To: michaelc@cs.wisc.edu
Cc: linux-scsi@vger.kernel.org, Abhijeet Joglekar <abjoglek@cisco.com>
Subject: Re: [RFC PATCH 6/7] fnic: hook scsi eh into fc_block_scsi_eh
Date: Thu, 23 Sep 2010 00:37:53 -0500 [thread overview]
Message-ID: <4C9AE7B1.9030609@cs.wisc.edu> (raw)
In-Reply-To: <1285219045-14645-7-git-send-email-michaelc@cs.wisc.edu>
On 09/23/2010 12:17 AM, michaelc@cs.wisc.edu wrote:
> From: Mike Christie<michaelc@cs.wisc.edu>
>
> fnic is calling fc_block_scsi_eh, but it is not passing
> up TRANSPORT_FAILED if returned.
>
> Signed-off-by: Mike Christie<michaelc@cs.wisc.edu>
I did not mean to send this patch for fnic.
It does not always work, because because fnic's terminate_rport_io
callback can fail and then relies on the scsi eh functions to clean up
the command. However, the fc_block_scsi_eh function relies on the
terminate_rport_io callback cleaning up the commands.
next prev parent reply other threads:[~2010-09-23 5:32 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-23 5:17 [RFC] FC class: misc fixes michaelc
2010-09-23 5:17 ` [RFC PATCH 1/7] fc class: fix rport re-add dev_loss handling race michaelc
2010-09-23 5:17 ` [RFC PATCH 2/7] fc class: remove fc_flush_work in fc_remote_port_add michaelc
2010-09-23 5:17 ` [RFC PATCH 3/7] scsi error: rename FAST_IO_FAIL to TRANSPORT_FAILED michaelc
2010-09-23 5:17 ` [RFC PATCH 4/7] fc class: don't return from fc_block_scsi_eh until IO has been cleaned up michaelc
2010-09-23 5:47 ` Mike Christie
2010-09-23 7:18 ` Hannes Reinecke
2010-09-23 5:17 ` [RFC PATCH 5/7] libfc: hook scsi eh into fc_block_scsi_eh michaelc
2010-09-23 5:17 ` [RFC PATCH 6/7] fnic: " michaelc
2010-09-23 5:37 ` Mike Christie [this message]
2010-09-23 5:17 ` [RFC PATCH 7/7] qla2xxx: " michaelc
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C9AE7B1.9030609@cs.wisc.edu \
--to=michaelc@cs.wisc.edu \
--cc=abjoglek@cisco.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.