From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jeff Garzik <jeff@garzik.org>
Subject: Re: [PATCH tabled] server/server.c (net_write_port): Don't ignore
 write error.
Date: Thu, 23 Sep 2010 04:18:27 -0400
Message-ID: <4C9B0D53.8050603@garzik.org>
References: <87bp7ozyg4.fsf@meyering.net>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Return-path: <hail-devel-owner@vger.kernel.org>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=gamma;
        h=domainkey-signature:received:received:sender:message-id:date:from
         :user-agent:mime-version:to:cc:subject:references:in-reply-to
         :content-type:content-transfer-encoding;
        bh=PN6csfJMZDRcKLQdBfuKQPEuKwrHqRP9RGtkLowrjSI=;
        b=YI6TCn/Fo0KC4Kb9CbHBIf9g/lLtV1fmV1865eld1euNT4/eKdZIi4gqNO+jpfjxh4
         lxc67SJPUNsPrLAXl5nm10hcQwmx628ZdyjeR1PVYW1kmCjBiqSsqwXHMBAycuVRjsUm
         VzIJQHYxOSlg+xegv5wy5CfuhVzrE4F9n0Wuk=
In-Reply-To: <87bp7ozyg4.fsf@meyering.net>
Sender: hail-devel-owner@vger.kernel.org
List-ID: <hail-devel.vger.kernel.org>
Content-Type: text/plain; charset="us-ascii"; format="flowed"
To: Jim Meyering <jim@meyering.net>
Cc: Project Hail <hail-devel@vger.kernel.org>

On 09/23/2010 03:55 AM, Jim Meyering wrote:
> Better safe than sorry...
> Unreported write failures can be unpleasant.
> I fixed the one below so that a failure indication
> can propagate up the call tree.  You might also want to
> report the failure to stderr.
>
> I let my editor automatically update the copyright date
> and remove trailing spaces.
> If you'd rather separate those from the fix,
> let me know and I can adjust and resend.

Patch applied, thanks.

The typical preference is to receive whitespace and other cosmetic 
changes in a separate patch, thereby highlighting the functional changes.

But we're not so strict here that I would reject an otherwise useful 
patch...

Also FWIW, we're not very strict about reproducing the GCC-ish 
(GNU-ish?) style of "$FILENAME ($FUNCTION):" in each changelog -- though 
you're certainly welcome to continue, if that's your preference.

Given that "git show $COMMIT" will give you filename and per-diff-chunk 
function names, reproducing that in the git changelog entry seems 
somewhat redundant.  A simple, English-language summary of the change is 
fine.  Just a style tip, though, feel free to ignore!  :)

	Jeff