Re: [PATCH] mmc: add SDHCI driver for STM platforms (V2)

[Peppe CAVALLARO <peppe.cavallaro@st.com>]

On 09/23/2010 11:51 AM, Wolfram Sang wrote:
> 
>> static int mmc_pad_resources(struct sdhci_host *sdhci)
>> {
>>         if (!devm_stm_pad_claim(sdhci->mmc->parent,
>>                                 &stx7108_mmc_pad_config,
>>                                 dev_name(sdhci->mmc->parent)))
>>                 return -ENODEV;
>>
>>         return 0;
>> }
>>
>> static struct sdhci_pltfm_data stx7108_mmc_platform_data = {
>>                 .init = &mmc_pad_resources,
> 
> You can drop the &

Thx ;-)

> 
>>                 .quirks = SDHCI_QUIRK_NO_ENDATTR_IN_NOPDESC,
>> };
>>
>> static struct platform_device stx7108_mmc_device = {
>>                 .name = "sdhci",
>>
>> [snip]
> 
> All in all, this looks like the right way! A good example how to
> slightly update and then use the pltfm-driver. Redundant code saved and
> benefits for all added :)

Regards,
Peppe

> Regards,
> 
>    Wolfram
>