From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Garzik Subject: Re: [tabled patch] abstract out TCP-write code Date: Thu, 23 Sep 2010 12:47:54 -0400 Message-ID: <4C9B84BA.6040908@garzik.org> References: <20100923000908.GA15908@havoc.gtf.org> <20100922182836.566df309@lembas.zaitcev.lan> <4C9AACB5.40403@garzik.org> <20100922203741.48a2b8e6@lembas.zaitcev.lan> <4C9AD849.8030404@garzik.org> <20100923075706.4952c527@lembas.zaitcev.lan> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:sender:message-id:date:from :user-agent:mime-version:to:cc:subject:references:in-reply-to :content-type:content-transfer-encoding; bh=RLzbuqSJoeKhlLXUpgTjYtuVO/P+ZTWbSRT2XPa1sQg=; b=TD0PAwEkai2AeLQ2mKo+2M4OUcRlGiqz2VM9VmK6Tg123I8AZ/M4LXyYuqqT3Ei3Mn jATL7OgfjhvHkX6Mdxh1F29zxXQ2gIpDDL0h8HvlS1ZwCGICFPCRoIlQ7+FTZ3RzcUsh 0pJhEDJ0/1dANDcUDLpjImxJ8ORwSxO1FOGok= In-Reply-To: <20100923075706.4952c527@lembas.zaitcev.lan> Sender: hail-devel-owner@vger.kernel.org List-ID: Content-Type: text/plain; charset="us-ascii"; format="flowed" To: Pete Zaitcev Cc: hail-devel@vger.kernel.org On 09/23/2010 09:57 AM, Pete Zaitcev wrote: > Side effect or not, if one applies your patch and executes > "export MALLOC_PERTURB_=43" command before "make check", > the result is a crash: Yes, it is clear my patch re-introduces the problem. I thanked you for pointing that out in the original reply. :) The point was, that does not invalidate the approach of storing write_compl_q in struct atcp_wr_state. It merely highlights that a further fix (to the FSM? refcount client? etc.) is required. Jeff