From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH 2/2] Fix __ofono_voicecall_is_busy()
Date: Thu, 23 Sep 2010 13:30:58 -0500 [thread overview]
Message-ID: <4C9B9CE2.3060002@gmail.com> (raw)
In-Reply-To: <1285263737-9017-2-git-send-email-Pekka.Pessi@nokia.com>
[-- Attachment #1: Type: text/plain, Size: 460 bytes --]
Hi Pekka,
> @@ -2171,7 +2171,7 @@ int ofono_voicecall_get_next_callid(struct ofono_voicecall *vc)
> ofono_bool_t __ofono_voicecall_is_busy(struct ofono_voicecall *vc,
> enum ofono_voicecall_interaction type)
> {
> - if (vc->pending)
> + if (vc->pending || vc->dial_req)
> return TRUE;
>
> switch (type) {
This particular change breaks __ofono_voicecall_dial which would return
EBUSY in all cases as a result.
Regards,
-Denis
next prev parent reply other threads:[~2010-09-23 18:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-23 17:42 [PATCH 1/2] Fix valid_ussd_string() Pekka.Pessi
2010-09-23 17:42 ` [PATCH 2/2] Fix __ofono_voicecall_is_busy() Pekka.Pessi
2010-09-23 18:30 ` Denis Kenzior [this message]
2010-09-23 18:27 ` [PATCH 1/2] Fix valid_ussd_string() Denis Kenzior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C9B9CE2.3060002@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.