From: Jeff Garzik <jeff@garzik.org>
To: Pete Zaitcev <zaitcev@redhat.com>
Cc: Jim Meyering <jim@meyering.net>,
Project Hail <hail-devel@vger.kernel.org>
Subject: Re: [PATCH tabled] server/bucket.c: don't deref NULL upon failed malloc
Date: Thu, 23 Sep 2010 15:32:04 -0400 [thread overview]
Message-ID: <4C9BAB34.4080804@garzik.org> (raw)
In-Reply-To: <20100923080350.09e7dffc@lembas.zaitcev.lan>
On 09/23/2010 10:03 AM, Pete Zaitcev wrote:
> On Thu, 23 Sep 2010 12:53:06 +0200
> Jim Meyering<jim@meyering.net> wrote:
>
>> I factored out the append_const definition to avoid
>> having to wrap the long lines with the increased indentation.
>
>> p = s;
>>
>> +#define append_const(buf, c) \
>> + do { memcpy(buf, c, sizeof(c)-1); (buf) += sizeof(c)-1; } while (0)
>> +
>> tmpl = pfx_list;
>> while (tmpl) {
>
> Dunno about Jeff, but I would definitely put an #undef to it
> after the loop, just in case.
Yeah, or after the function.
prev parent reply other threads:[~2010-09-23 19:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-23 10:53 [PATCH tabled] server/bucket.c: don't deref NULL upon failed malloc Jim Meyering
2010-09-23 14:03 ` Pete Zaitcev
2010-09-23 19:32 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C9BAB34.4080804@garzik.org \
--to=jeff@garzik.org \
--cc=hail-devel@vger.kernel.org \
--cc=jim@meyering.net \
--cc=zaitcev@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.