From: Stefan Weil <weil@mail.berlios.de>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: QEMU Developers <qemu-devel@nongnu.org>
Subject: [Qemu-devel] Re: [PATCH 2/3] Replace remaining gcc format attribute by macro GCC_FMT_ATTR (format checking)
Date: Thu, 23 Sep 2010 22:44:27 +0200 [thread overview]
Message-ID: <4C9BBC2B.2030004@mail.berlios.de> (raw)
In-Reply-To: <AANLkTik0zTpZagGwWFcHB55+veoP5mdHgvM4qg59n8f9@mail.gmail.com>
Am 23.09.2010 22:33, schrieb Blue Swirl:
> On Thu, Sep 23, 2010 at 7:28 PM, Stefan Weil <weil@mail.berlios.de> wrote:
>> Replace the remaining format attribute printf by macro
>> GCC_FMT_ATTR which uses gnu_printf (if supported).
>>
>> This needs additional code changes:
>>
>> * Add qemu-common.h (which defined GCC_FMT_ATTR) were needed.
>>
>> * Remove standard includes when qemu-common.h was added.
>> qemu-common.h already provides these includes.
>>
>> * Remove local definitions which now come from stdio.h.
>> These definitions were needed before tcg was introduced.
>> They raise conflicts when qemu-common.h is included.
>
> IIRC the problem was that some system headers were incompatible with
> global asm variables. There is still one, AREG0.
>
> But I'd rather not keep the hideous local definitions forever. Maybe
> those systems which are broken by the patch are not interesting
> anymore?
Are there such systems? Or did the problems with earlier
versions arise from the fact that a lot of global asm variables
were reserved by qemu? How could a correctly defined AREG0
interfere with system headers?
For linux and win32, I did not notice problems caused by these changes.
next prev parent reply other threads:[~2010-09-23 20:44 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-23 19:28 [Qemu-devel] [PATCH 1/3] Replace most gcc format attributes by macro GCC_FMT_ATTR (format checking) Stefan Weil
2010-09-23 19:28 ` [Qemu-devel] [PATCH 2/3] Replace remaining gcc format attribute " Stefan Weil
2010-09-23 20:33 ` [Qemu-devel] " Blue Swirl
2010-09-23 20:44 ` Stefan Weil [this message]
2010-09-25 7:46 ` Blue Swirl
2010-10-04 19:29 ` [Qemu-devel] [RFC] Can we remove special handling of standard headers (introduced for dyngen / OSX?) Stefan Weil
2010-10-09 22:46 ` Andreas Färber
2010-10-11 16:22 ` Stefan Weil
2010-10-12 18:33 ` Blue Swirl
2010-10-12 18:23 ` [Qemu-devel] Re: [PATCH 2/3] Replace remaining gcc format attribute by macro GCC_FMT_ATTR (format checking) Blue Swirl
2010-09-23 19:28 ` [Qemu-devel] [PATCH 3/3] Use " Stefan Weil
2010-10-03 7:49 ` Blue Swirl
2010-10-03 7:48 ` [Qemu-devel] Re: [PATCH 1/3] Replace most gcc format attributes by macro " Blue Swirl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C9BBC2B.2030004@mail.berlios.de \
--to=weil@mail.berlios.de \
--cc=blauwirbel@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.