From: "Vladimir 'φ-coder/phcoder' Serbinenko" <phcoder@gmail.com>
To: grub-devel@gnu.org
Subject: Re: [PATCH] Uninitialized variable
Date: Fri, 24 Sep 2010 00:39:49 +0200 [thread overview]
Message-ID: <4C9BD735.3000104@gmail.com> (raw)
In-Reply-To: <4C9B861D.9000106@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1171 bytes --]
On 09/23/2010 06:53 PM, Grégoire Sutre wrote:
> Hi,
>
> This is catched (as a warning) by gcc 4.1.3 -- gcc 4.4 does not
> complain (maybe some command-line option is missing?).
>
> Grégoire
>
>
> 2010-09-23 Grégoire Sutre <gregoire.sutre@gmail.com>
>
> * grub-core/commands/acpihalt.c (get_sleep_type): Initialize prev.
>
> === modified file 'grub-core/commands/acpihalt.c'
> --- grub-core/commands/acpihalt.c 2010-09-13 18:29:15 +0000
> +++ grub-core/commands/acpihalt.c 2010-09-23 13:23:46 +0000
> @@ -134,11 +134,11 @@ skip_ext_op (const grub_uint8_t *ptr, co
> }
>
> static int
> get_sleep_type (grub_uint8_t *table, grub_uint8_t *end)
> {
> - grub_uint8_t *ptr, *prev;
> + grub_uint8_t *ptr, *prev = 0;
> int sleep_type = -1;
>
It should be prev = table; Other than that go ahead.
> ptr = table + sizeof (struct grub_acpi_table_header);
> while (ptr < end && prev < ptr)
> {
>
>
>
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> http://lists.gnu.org/mailman/listinfo/grub-devel
>
--
Regards
Vladimir 'φ-coder/phcoder' Serbinenko
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 294 bytes --]
prev parent reply other threads:[~2010-09-23 22:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-23 16:53 [PATCH] Uninitialized variable Grégoire Sutre
2010-09-23 22:39 ` Vladimir 'φ-coder/phcoder' Serbinenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C9BD735.3000104@gmail.com \
--to=phcoder@gmail.com \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.