From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1OyuSV-00070o-JP for mharc-grub-devel@gnu.org; Thu, 23 Sep 2010 18:40:07 -0400 Received: from [140.186.70.92] (port=47666 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OyuSS-0006zi-L5 for grub-devel@gnu.org; Thu, 23 Sep 2010 18:40:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OyuSR-0006Ci-HK for grub-devel@gnu.org; Thu, 23 Sep 2010 18:40:04 -0400 Received: from mail-fx0-f41.google.com ([209.85.161.41]:52799) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OyuSR-0006CU-BC for grub-devel@gnu.org; Thu, 23 Sep 2010 18:40:03 -0400 Received: by fxm10 with SMTP id 10so1745921fxm.0 for ; Thu, 23 Sep 2010 15:40:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from :user-agent:mime-version:to:subject:references:in-reply-to :x-enigmail-version:content-type; bh=O4WuVx+XB+Jri9F3duF/RSNhMEIFj1h9oq8hUtw+5lg=; b=srl9D1NaWKEHK6Ktrdo0m/bIw2hHWTqLF80pgmH4uNTfM/5B0y7fSoiFswm/yMCII7 Uv6HzAUECaTKxVT8x1weYiEwg3dDYbmu2hD1Risw5J1Yzbi42RVWKSczAhbPa6I7f0e0 KjLPUyi8GaFh5YG3wGJGyFWQuuKbDvdH5hKMo= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:x-enigmail-version:content-type; b=wT/J18xLnMwVwvmLKsMUfbp1Y/tXssY1otwtbcpQs4FrlPd3F0oFJvRSnnw/epJOhm 3TfnFkMFA4J3DiNkDIwiXe+DZaZLlUhddSKEOMF8LRRRwZ8xj/ilkNFWpbpPBcqBGacb FZwClRTommhtOQjNpdqMXI2haKjC3woqE3zUM= Received: by 10.223.119.74 with SMTP id y10mr2681284faq.81.1285281600152; Thu, 23 Sep 2010 15:40:00 -0700 (PDT) Received: from debian.bg45.phnet (gprs13.swisscom-mobile.ch [193.247.250.13]) by mx.google.com with ESMTPS id k15sm651854fai.16.2010.09.23.15.39.57 (version=TLSv1/SSLv3 cipher=RC4-MD5); Thu, 23 Sep 2010 15:39:58 -0700 (PDT) Message-ID: <4C9BD735.3000104@gmail.com> Date: Fri, 24 Sep 2010 00:39:49 +0200 From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.11) Gecko/20100805 Icedove/3.0.6 MIME-Version: 1.0 To: grub-devel@gnu.org References: <4C9B861D.9000106@gmail.com> In-Reply-To: <4C9B861D.9000106@gmail.com> X-Enigmail-Version: 1.0.1 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="------------enig8309FB631975DE1D296C9C16" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) Subject: Re: [PATCH] Uninitialized variable X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Sep 2010 22:40:05 -0000 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig8309FB631975DE1D296C9C16 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 09/23/2010 06:53 PM, Gr=C3=A9goire Sutre wrote: > Hi, > > This is catched (as a warning) by gcc 4.1.3 -- gcc 4.4 does not > complain (maybe some command-line option is missing?). > > Gr=C3=A9goire > > > 2010-09-23 Gr=C3=A9goire Sutre > > * grub-core/commands/acpihalt.c (get_sleep_type): Initialize prev. > > =3D=3D=3D modified file 'grub-core/commands/acpihalt.c' > --- grub-core/commands/acpihalt.c 2010-09-13 18:29:15 +0000 > +++ grub-core/commands/acpihalt.c 2010-09-23 13:23:46 +0000 > @@ -134,11 +134,11 @@ skip_ext_op (const grub_uint8_t *ptr, co > } > > static int > get_sleep_type (grub_uint8_t *table, grub_uint8_t *end) > { > - grub_uint8_t *ptr, *prev; > + grub_uint8_t *ptr, *prev =3D 0; > int sleep_type =3D -1; > It should be prev =3D table; Other than that go ahead. > ptr =3D table + sizeof (struct grub_acpi_table_header); > while (ptr < end && prev < ptr) > { > > > > _______________________________________________ > Grub-devel mailing list > Grub-devel@gnu.org > http://lists.gnu.org/mailman/listinfo/grub-devel > --=20 Regards Vladimir '=CF=86-coder/phcoder' Serbinenko --------------enig8309FB631975DE1D296C9C16 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iF4EAREKAAYFAkyb1zsACgkQNak7dOguQgli8gEAxE3rrkUdmeXp2EMkulzVD8Xn wLKn/RBBntxeWgs7/qQA/0M7nB1dL4Bb2/r7c6el4HFwZPm8zRTXfXv0Fi6HgOvM =gYAS -----END PGP SIGNATURE----- --------------enig8309FB631975DE1D296C9C16--