From: Ben Dooks <ben@simtec.co.uk>
To: Maurus Cuelenaere <mcuelenaere@gmail.com>
Cc: linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, kgene.kim@samsung.com,
ben-linux@fluff.org
Subject: Re: [PATCH] ARM: SAMSUNG: make SAMSUNG_PM_DEBUG select DEBUG_LL
Date: Fri, 24 Sep 2010 00:54:34 +0100 [thread overview]
Message-ID: <4C9BE8BA.7000804@simtec.co.uk> (raw)
In-Reply-To: <4c920aa8.d37b0e0a.4ee4.ffffc4bc@mx.google.com>
On 16/09/10 13:16, Maurus Cuelenaere wrote:
> When selecting SAMSUNG_PM_DEBUG, it complains about a missing printascii()
> function if you do not select DEBUG_LL, so make the former select the latter.
>
> Signed-off-by: Maurus Cuelenaere <mcuelenaere@gmail.com>
> ---
> arch/arm/plat-samsung/Kconfig | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/plat-samsung/Kconfig b/arch/arm/plat-samsung/Kconfig
> index 7c0bde7..d5816e7 100644
> --- a/arch/arm/plat-samsung/Kconfig
> +++ b/arch/arm/plat-samsung/Kconfig
> @@ -260,6 +260,7 @@ comment "Power management"
> config SAMSUNG_PM_DEBUG
> bool "S3C2410 PM Suspend debug"
> depends on PM
> + select DEBUG_LL
> help
> Say Y here if you want verbose debugging from the PM Suspend and
> Resume code. See <file:Documentation/arm/Samsung-S3C24XX/Suspend.txt>
Either this, or having SAMSUNG_PM_DEBUG depend on DEBUG_LL.. Personally
I think this is probably best, unless it's offensive to anyone else?
--
Ben
WARNING: multiple messages have this Message-ID (diff)
From: ben@simtec.co.uk (Ben Dooks)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: SAMSUNG: make SAMSUNG_PM_DEBUG select DEBUG_LL
Date: Fri, 24 Sep 2010 00:54:34 +0100 [thread overview]
Message-ID: <4C9BE8BA.7000804@simtec.co.uk> (raw)
In-Reply-To: <4c920aa8.d37b0e0a.4ee4.ffffc4bc@mx.google.com>
On 16/09/10 13:16, Maurus Cuelenaere wrote:
> When selecting SAMSUNG_PM_DEBUG, it complains about a missing printascii()
> function if you do not select DEBUG_LL, so make the former select the latter.
>
> Signed-off-by: Maurus Cuelenaere <mcuelenaere@gmail.com>
> ---
> arch/arm/plat-samsung/Kconfig | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/plat-samsung/Kconfig b/arch/arm/plat-samsung/Kconfig
> index 7c0bde7..d5816e7 100644
> --- a/arch/arm/plat-samsung/Kconfig
> +++ b/arch/arm/plat-samsung/Kconfig
> @@ -260,6 +260,7 @@ comment "Power management"
> config SAMSUNG_PM_DEBUG
> bool "S3C2410 PM Suspend debug"
> depends on PM
> + select DEBUG_LL
> help
> Say Y here if you want verbose debugging from the PM Suspend and
> Resume code. See <file:Documentation/arm/Samsung-S3C24XX/Suspend.txt>
Either this, or having SAMSUNG_PM_DEBUG depend on DEBUG_LL.. Personally
I think this is probably best, unless it's offensive to anyone else?
--
Ben
next prev parent reply other threads:[~2010-09-23 23:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-16 12:16 [PATCH] ARM: SAMSUNG: make SAMSUNG_PM_DEBUG select DEBUG_LL Maurus Cuelenaere
2010-09-16 12:16 ` Maurus Cuelenaere
2010-09-23 23:54 ` Ben Dooks [this message]
2010-09-23 23:54 ` Ben Dooks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C9BE8BA.7000804@simtec.co.uk \
--to=ben@simtec.co.uk \
--cc=ben-linux@fluff.org \
--cc=kgene.kim@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mcuelenaere@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.