All of lore.kernel.org
 help / color / mirror / Atom feed
From: Shinya Kuribayashi <shinya.kuribayashi.px@renesas.com>
To: linux-mtd@lists.infradead.org
Subject: [PATCH] nandwrite: Remove redundant 'autoplace' check
Date: Fri, 24 Sep 2010 18:22:53 +0900	[thread overview]
Message-ID: <4C9C6DED.5040200@renesas.com> (raw)

We're already in 'if (autoplace) { }' block at ths moment.

Signed-off-by: Shinya Kuribayashi <shinya.kuribayashi.px@renesas.com>
---

 Along with Mike's nandwrite patches, I'd like to toss out a trivial
 one, too ;-)

 nandwrite.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/nandwrite.c b/nandwrite.c
index 8fe8875..9eb2004 100644
--- a/nandwrite.c
+++ b/nandwrite.c
@@ -331,7 +331,7 @@ int main(int argc, char * const argv[])
 		}
 
 		// autoplace ECC ?
-		if (autoplace && (old_oobinfo.useecc != MTD_NANDECC_AUTOPLACE)) {
+		if (old_oobinfo.useecc != MTD_NANDECC_AUTOPLACE) {
 
 			if (ioctl (fd, MEMSETOOBSEL, &autoplace_oobinfo) != 0) {
 				perror ("MEMSETOOBSEL");
-- 
1.7.2.3
-- 
Shinya Kuribayashi
Renesas Electronics

             reply	other threads:[~2010-09-24  9:23 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-24  9:22 Shinya Kuribayashi [this message]
2010-09-25 10:57 ` [PATCH] nandwrite: Remove redundant 'autoplace' check Artem Bityutskiy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C9C6DED.5040200@renesas.com \
    --to=shinya.kuribayashi.px@renesas.com \
    --cc=linux-mtd@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.