From: "Grégoire Sutre" <gregoire.sutre@gmail.com>
To: grub-devel@gnu.org
Subject: Re: [PATCH] Fix getline name clash
Date: Fri, 24 Sep 2010 12:37:07 +0200 [thread overview]
Message-ID: <4C9C7F53.8070409@gmail.com> (raw)
In-Reply-To: <20100924101858.GG21862@riva.ucam.org>
On 09/24/2010 12:18, Colin Watson wrote:
> This looks good to me as far as it goes, but doesn't it need a bit more?
I guess we should not rename the actual calls to the getline() library
function (otherwise gnulib's replacement won't help). And I personally
don't mind if function arguments and local variables are substituted.
But I agree that, in general, it would be safer to avoid names that
might be inadvertently replaced by gnulib's #defines.
Grégoire
next prev parent reply other threads:[~2010-09-24 10:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-23 11:36 [PATCH] Fix getline name clash Grégoire Sutre
2010-09-24 10:18 ` Colin Watson
2010-09-24 10:37 ` Grégoire Sutre [this message]
2010-10-19 9:17 ` BVK Chaitanya
2010-10-19 12:39 ` Grégoire Sutre
2010-10-22 21:56 ` Vladimir 'φ-coder/phcoder' Serbinenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C9C7F53.8070409@gmail.com \
--to=gregoire.sutre@gmail.com \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.