Re: [wireless] wireless: Keep phy name consistent across module reloads.

[Ben Greear <greearb@candelatech.com>]

On 09/24/2010 03:25 PM, Johannes Berg wrote:
> On Fri, 2010-09-24 at 15:21 -0700, Ben Greear wrote:
>
>> Here's a patch for consideration.  It's on top of my other patch,
>> but I can re-do it against a tree with that reverted if you prefer.
>
> You also want to remove the restriction on renaming to phy%d now.

Same patch, or a second one?

>> +	if (unlikely(!wiphy_idx_valid(rdev->wiphy_idx)))
>> +		goto too_many_devs;
>> +
>>    	/* 64k wiphy devices is enough for anyone! */
>>    	for (i = 0; i<  0xFFFF; i++) {
>
> why limit yourself to this? You're guaranteed to find a free index if
> you don't, so error handling could be easier?

It's an N^2 loop, and if we are unlikely to ever need more than 512 STAs, I figure
64k phys is probably enough. :)

But, will change it if you want.

Thanks,
Ben

-- 
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc  http://www.candelatech.com