From: Avi Kivity <avi@redhat.com>
To: Xiao Guangrong <xiaoguangrong@cn.fujitsu.com>
Cc: Marcelo Tosatti <mtosatti@redhat.com>,
LKML <linux-kernel@vger.kernel.org>, KVM <kvm@vger.kernel.org>
Subject: Re: [PATCH 2/4] KVM: MMU: support unsync sp out of the protection of 'mmu_lock'
Date: Sun, 26 Sep 2010 15:02:35 +0200 [thread overview]
Message-ID: <4C9F446B.1030902@redhat.com> (raw)
In-Reply-To: <4C9AC3EB.1080507@cn.fujitsu.com>
On 09/23/2010 05:05 AM, Xiao Guangrong wrote:
> >
> > How can you drop an active unsync page?
> >
> > I'm missing something here.
> >
>
> Umm, this feature is used like this:
>
> hold mmu_lock
> increase sp->active_count
> release mmu_lock
> ......
> hold mmu_lock
> increase sp->active_count
> if (!sp->active_count&& sp->invalid)
> kvm_mmu_free_page(sp);
> ......
> release mmu_lock
>
>
Well, the implementation is confusing. Maybe we should have
mmu_ref_sp() and mmu_drop_sp() wrappers to manage the reference counts
and call mmu_free_page() automatically.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2010-09-26 13:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-20 14:18 [PATCH 1/4] KVM: MMU: rename 'sp->root_count' to 'sp->active_count' Xiao Guangrong
2010-09-20 14:19 ` [PATCH 2/4] KVM: MMU: support unsync sp out of the protection of 'mmu_lock' Xiao Guangrong
2010-09-20 15:19 ` Avi Kivity
2010-09-23 3:05 ` Xiao Guangrong
2010-09-26 13:02 ` Avi Kivity [this message]
2010-09-20 14:20 ` [PATCH 3/4] KVM: MMU: move reserved bits check to FNAME(update_pte) Xiao Guangrong
2010-09-20 14:21 ` [PATCH 4/4] KVM: MMU: Don't touch unsync sp in kvm_mmu_pte_write() Xiao Guangrong
2010-09-20 15:24 ` Avi Kivity
2010-09-23 2:59 ` Xiao Guangrong
2010-09-26 13:09 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C9F446B.1030902@redhat.com \
--to=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=xiaoguangrong@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.