Re: [PATCH v2] machine/sh7785lcr: Add new machine for Renesas SH7785 reference board

["Eric Bénard" <eric@eukrea.com>]

Hi,

Le 26/09/2010 22:42, Nobuhiro Iwamatsu a écrit :
> 2010/9/25 Khem Raj<raj.khem@gmail.com>:
>> On Fri, Sep 24, 2010 at 2:56 PM, Nobuhiro Iwamatsu<iwamatsu@nigauri.org>  wrote:
>>> --- a/conf/machine/include/tune-sh4.inc
>>> +++ b/conf/machine/include/tune-sh4.inc
>>> @@ -1,3 +1,5 @@
>>> +# If you want to optimize to sh4a, you need to change
>>> +# from -m4 to m4a.
>>>   TARGET_CC_ARCH = "-ml -m4"
>>>   FEED_ARCH = "sh4"
>>>   BASE_PACKAGE_ARCH = "sh4"
>>
>> you could add another tune file for sh4a called
>> tune-sh4a.inc and include that for appropriate
>> machines. rest of patch looks good to me.
>
> I want to make optimization of m4 a default.
> The reason is because there is not compatibility in m4 and m4a.
> It is a memo for the person whom it wants to optimize in m4a that I
> wrote in tune-sh4.inc.
>
> I thought that I have had better take off a memo if confusion happened
> by this memo.
> How do you think?
>
As Khem said, it's better to have tune-sh4a.inc & tune-sh4.inc in the 
include directory which let the user the possibility to include the one 
he wants in his machine configuration file (without the need to modifiy 
the include file).

Eric