From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH 2/5] stk: Support send ss response
Date: Sun, 26 Sep 2010 19:48:48 -0500 [thread overview]
Message-ID: <4C9FE9F0.2020509@gmail.com> (raw)
In-Reply-To: <1285064479-12907-3-git-send-email-yang.gu@intel.com>
[-- Attachment #1: Type: text/plain, Size: 584 bytes --]
Hi Yang,
On 09/21/2010 05:21 AM, Yang Gu wrote:
> ---
> src/stkutil.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/src/stkutil.c b/src/stkutil.c
> index cdd6b4e..d35094b 100644
> --- a/src/stkutil.c
> +++ b/src/stkutil.c
> @@ -5449,6 +5449,8 @@ const unsigned char *stk_pdu_from_response(const struct stk_response *response,
> &response->select_item.item_id,
> NULL);
> break;
> + case STK_COMMAND_TYPE_SEND_SS:
> + break;
This seems wrong, isn't the additional information field mandatory?
Regards,
-Denis
next prev parent reply other threads:[~2010-09-27 0:48 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-21 10:21 [PATCH 0/5] Patch Description Yang Gu
2010-09-21 10:21 ` [PATCH 1/5] Add macro for general result and additional info Yang Gu
2010-09-27 0:47 ` Denis Kenzior
2010-09-21 10:21 ` [PATCH 2/5] stk: Support send ss response Yang Gu
2010-09-27 0:48 ` Denis Kenzior [this message]
2010-10-18 8:04 ` Gu, Yang
2010-10-18 17:30 ` andrzej zaborowski
2010-10-18 22:34 ` Denis Kenzior
2010-09-21 10:21 ` [PATCH 3/5] ss: Use function to judge if it's busy Yang Gu
2010-09-27 1:05 ` Denis Kenzior
2010-09-21 10:21 ` [PATCH 4/5] ss: Use errno for ssc handling functions Yang Gu
2010-09-27 1:01 ` Denis Kenzior
2010-09-21 10:21 ` [PATCH 5/5] cf: Handle send ss proactive command Yang Gu
2010-09-21 19:28 ` Jeevaka.Badrappan
2010-09-27 2:11 ` Gu, Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C9FE9F0.2020509@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.