From: "H. Peter Anvin" <hpa@zytor.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, Ingo Molnar <mingo@elte.hu>,
Thomas Gleixner <tglx@linutronix.de>,
"Volodymyr G. Lukiianyk" <volodymyrgl@gmail.com>,
Alexander Chumachenko <ledest@gmail.com>,
Glauber de Oliveira Costa <gcosta@redhat.com>
Subject: Re: fs hang in 2.6.27.y | Fwd: [Bug 15658] New: [PATCH] x86 constant_test_bit() prone to misoptimization with gcc-4.4
Date: Sun, 26 Sep 2010 21:27:18 -0700 [thread overview]
Message-ID: <4CA01D26.3030906@zytor.com> (raw)
In-Reply-To: <AANLkTiniAprv-rz0QQD540g7S1jbj8Na+e78Ro2R8Koa@mail.gmail.com>
On 09/26/2010 10:00 AM, Linus Torvalds wrote:
> On Sun, Sep 26, 2010 at 4:53 AM, Michael Shigorin<mike@osdn.org.ua> wrote:
>>
>> The simplicity of adding that somewhat went over my head --
>> please find attached the corrected original patch against HEAD
>> with Signed-off-by: for both of us. led@ didn't change cosmetics
>> -- thanks for providing it anyways.
>
> Ok, I think this patch is probably the right thing to do at this stage
> - and we should think about trying to see if we can improve code
> generation later.
>
> So: "Acked-by: Linus Torvalds<torvalds@linux-foundation.org>"
>
> Ingo/Thomas/Peter - I can take this either from the x86 tree, or
> directly. Just let me know. Or do you have any alternate suggestions
> that would be appropriate?
>
(Back home now)
Yes, this patch is clearly The Right Thing. I'll add it to the -tip
tree and assuming no unexpected problems will send you a pull request
tomorrow.
-hpa
prev parent reply other threads:[~2010-09-27 4:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-27 21:36 fs hang in 2.6.27.y | Fwd: [Bug 15658] New: [PATCH] x86 constant_test_bit() prone to misoptimization with gcc-4.4 Michael Shigorin
2010-09-23 23:50 ` Andrew Morton
2010-09-24 7:05 ` Michael Shigorin
2010-09-26 11:53 ` Michael Shigorin
2010-09-26 17:00 ` Linus Torvalds
2010-09-26 20:19 ` H. Peter Anvin
2010-09-27 4:27 ` H. Peter Anvin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CA01D26.3030906@zytor.com \
--to=hpa@zytor.com \
--cc=akpm@linux-foundation.org \
--cc=gcosta@redhat.com \
--cc=ledest@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=volodymyrgl@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.