From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758953Ab0I0Ihd (ORCPT ); Mon, 27 Sep 2010 04:37:33 -0400 Received: from mail-out.m-online.net ([212.18.0.10]:54686 "EHLO mail-out.m-online.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755067Ab0I0Ihb (ORCPT ); Mon, 27 Sep 2010 04:37:31 -0400 X-Auth-Info: fnMF1u5NniGiyIrJ8d29HFy8/AVljX1DWa2xnxTomxk= Message-ID: <4CA057FA.1000101@grandegger.com> Date: Mon, 27 Sep 2010 10:38:18 +0200 From: Wolfgang Grandegger User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.12) Gecko/20100907 Fedora/3.0.7-1.fc12 Thunderbird/3.0.7 MIME-Version: 1.0 To: Masayuki Ohtak CC: "David S. Miller" , Wolfram Sang , Christian Pellegrin , Barry Song <21cnbao@gmail.com>, Samuel Ortiz , socketcan-core@lists.berlios.de, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, meego-dev@meego.com, andrew.chih.howe.khor@intel.com, qi.wang@intel.com, margie.foster@intel.com, yong.y.wang@intel.com, kok.howg.ewe@intel.com, Tomoya MORINAGA , joel.clark@intel.com Subject: Re: [MeeGo-Dev][PATCH v3] Topcliff: Update PCH_CAN driver to 2.6.35 References: <4C9C7C6F.1000003@dsn.okisemi.com> In-Reply-To: <4C9C7C6F.1000003@dsn.okisemi.com> X-Enigmail-Version: 1.0.1 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Ohtake, On 09/24/2010 12:24 PM, Masayuki Ohtak wrote: > Hi Wolfgang and Marc, > > We have modified a pretty amount of our driver based on other accepted Socket CAN driver. > Additionally, We have reduced the number of lines 3601 to 1444. Much better now! I need some more time for a full review, though. Thanks, Wolfgang. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wolfgang Grandegger Subject: Re: [MeeGo-Dev][PATCH v3] Topcliff: Update PCH_CAN driver to 2.6.35 Date: Mon, 27 Sep 2010 10:38:18 +0200 Message-ID: <4CA057FA.1000101@grandegger.com> References: <4C9C7C6F.1000003@dsn.okisemi.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: andrew.chih.howe.khor-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, Samuel Ortiz , margie.foster-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, socketcan-core-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org, yong.y.wang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, kok.howg.ewe-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, joel.clark-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, Tomoya MORINAGA , meego-dev-WXzIur8shnEAvxtiuMwx3w@public.gmane.org, "David S. Miller" , Christian Pellegrin , qi.wang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org To: Masayuki Ohtak Return-path: In-Reply-To: <4C9C7C6F.1000003-ECg8zkTtlr0C6LszWs/t0g@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: socketcan-core-bounces-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org Errors-To: socketcan-core-bounces-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org List-Id: netdev.vger.kernel.org Hi Ohtake, On 09/24/2010 12:24 PM, Masayuki Ohtak wrote: > Hi Wolfgang and Marc, > > We have modified a pretty amount of our driver based on other accepted Socket CAN driver. > Additionally, We have reduced the number of lines 3601 to 1444. Much better now! I need some more time for a full review, though. Thanks, Wolfgang.