All of lore.kernel.org
 help / color / mirror / Atom feed
From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: Please comment on callhistory API
Date: Mon, 27 Sep 2010 18:08:04 -0500	[thread overview]
Message-ID: <4CA123D4.9080500@gmail.com> (raw)
In-Reply-To: <1285609846.9845.11.camel@aeonflux>

[-- Attachment #1: Type: text/plain, Size: 1057 bytes --]

Hi Marcel,

On 09/27/2010 12:50 PM, Marcel Holtmann wrote:
> Hi Raji,
> 
>> CallHistory hierarchy
>> =============
>>
>> Service : org.ofono
>> Interface : org.ofono.CallHistory
>> Object path : [variable prefix]/{modem0,modem1,...}/CallHistory
> 
> the object path is wrong here. This should be pretty much on the main /
> object path. And not on per modem and not in a sub-path.
> 
> I really don't think that per modem history makes sense. Denis?

The idea here is that you can track history by the modem object or more
likely the IMSI.  Thus when switching SIMs or in dual-sim mode phones,
the history shown might change depending on the current SIM.

>> Properties
>> =======
>> 		integer Uid [Read Only]
>> 			Integer representing the unique id of the history record
> 
> In this case I would prefer UID as value and in uint32 please. D-Bus
> doesn't have an integer type.
> 
> Also do we actually need this? Denis?

This is not actually needed, we only track when a call has been ended or
missed.

Regards,
-Denis

  parent reply	other threads:[~2010-09-27 23:08 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-23 20:28 Please comment on callhistory API rajyalakshmi bommaraju
2010-09-24  1:17 ` Marcel Holtmann
2010-09-24 22:00   ` rajyalakshmi bommaraju
2010-09-27 17:50     ` Marcel Holtmann
2010-09-27 20:38       ` rajyalakshmi bommaraju
2010-09-27 22:21         ` Marcel Holtmann
2010-09-27 23:30           ` rajyalakshmi bommaraju
2010-09-28 14:08             ` Marcel Holtmann
2010-09-30 18:41               ` rajyalakshmi bommaraju
2010-10-01  7:33                 ` Marcel Holtmann
2010-10-20 23:38                   ` rajyalakshmi bommaraju
2010-09-27 23:08       ` Denis Kenzior [this message]
2010-09-27 23:14         ` Marcel Holtmann
2010-09-27 23:18           ` Denis Kenzior

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4CA123D4.9080500@gmail.com \
    --to=denkenz@gmail.com \
    --cc=ofono@ofono.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.