From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jeff Garzik <jeff@garzik.org>
Subject: Re: [PATCH hail] lib/hstor.c: avoid an unconditional leak in append_qparam
Date: Mon, 27 Sep 2010 20:23:55 -0400
Message-ID: <4CA1359B.6030304@garzik.org>
References: <87tylbeff1.fsf@meyering.net> <20100927102927.45686afa@lembas.zaitcev.lan>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Return-path: <hail-devel-owner@vger.kernel.org>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=gamma;
        h=domainkey-signature:received:received:sender:message-id:date:from
         :user-agent:mime-version:to:cc:subject:references:in-reply-to
         :content-type:content-transfer-encoding;
        bh=7j9FJPNCD9Bf+G6PXS8tDXsaMjjzMpUpn3kzVSptlTk=;
        b=PD3WH2oY9BiqOP1IbK4gF83RLDuTAnFoohAc4ZRdve+i98QJbuNpzn8/NZoX8rkPIl
         Qg7phoAXRA/GvO73HTreCHrbTX9a93USOonX83IqVtXdso+v33ZjWTo3rxQxksF9drkm
         mhTuC8m5akApXwXQEnZL+SL6vrmTAnpEhBqnI=
In-Reply-To: <20100927102927.45686afa@lembas.zaitcev.lan>
Sender: hail-devel-owner@vger.kernel.org
List-ID: <hail-devel.vger.kernel.org>
Content-Type: text/plain; charset="us-ascii"; format="flowed"
To: Pete Zaitcev <zaitcev@redhat.com>
Cc: Jim Meyering <jim@meyering.net>, Project Hail <hail-devel@vger.kernel.org>

On 09/27/2010 12:29 PM, Pete Zaitcev wrote:
> On Mon, 27 Sep 2010 10:53:06 +0200
> Jim Meyering<jim@meyering.net>  wrote:
>
>> -	stmp = huri_field_escape(strdup(val), QUERY_ESCAPE_MASK);
>> +	v = strdup(val);
>> +	stmp = huri_field_escape(v, QUERY_ESCAPE_MASK);
>>   	str = g_string_append(str, stmp);
>>   	free(stmp);
>> +	free(v);
>
> I think you may be fooled by the ridiculous calling convention

Doh, my memory and I were fooled, too.