From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760589Ab0I1Cih (ORCPT ); Mon, 27 Sep 2010 22:38:37 -0400 Received: from cn.fujitsu.com ([222.73.24.84]:59987 "EHLO song.cn.fujitsu.com" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1759997Ab0I1Cig (ORCPT ); Mon, 27 Sep 2010 22:38:36 -0400 Message-ID: <4CA15634.50300@cn.fujitsu.com> Date: Tue, 28 Sep 2010 10:43:00 +0800 From: Xiao Guangrong User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.11) Gecko/20100713 Thunderbird/3.0.6 MIME-Version: 1.0 To: Avi Kivity CC: Marcelo Tosatti , LKML , KVM Subject: Re: [PATCH 1/7] KVM: MMU: update 'root_hpa' out of loop in PAE shadow path References: <4CA06BA4.4090303@cn.fujitsu.com> <4CA06E9C.9060401@cn.fujitsu.com> <4CA0AC99.8000705@redhat.com> In-Reply-To: <4CA0AC99.8000705@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/27/2010 10:39 PM, Avi Kivity wrote: > On 09/27/2010 12:14 PM, Xiao Guangrong wrote: >> On 09/27/2010 06:02 PM, Xiao Guangrong wrote: >> > The value of 'vcpu->arch.mmu.pae_root' is not modified, so we can >> update 'root_hpa' >> > out of the loop >> > >> > Xiao Guangrong >> >> Hi Avi, Marcelo, >> >> I'm so sorry that missed "Signed-off-by: " string in all patches, i'll >> repost this >> patchset after your review. :-( > > I fixed up the signoffs and applied. Thanks Avi. I noticed you applied "KVM: MMU: rename 'sp->root_count' to 'sp->active_count'" (commit 55d80c448e7e3417) instead of this patch :-)