From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jeff Garzik <jeff@garzik.org>
Subject: Re: [hail patch 1/1] Fix calling convention of huri_field_escape
Date: Mon, 27 Sep 2010 22:47:05 -0400
Message-ID: <4CA15729.60203@garzik.org>
References: <20100927184918.7fec30ac@lembas.zaitcev.lan>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Return-path: <hail-devel-owner@vger.kernel.org>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=gamma;
        h=domainkey-signature:received:received:sender:message-id:date:from
         :user-agent:mime-version:to:cc:subject:references:in-reply-to
         :content-type:content-transfer-encoding;
        bh=r7HqAAlrb+6/8994BmQXMXk3/HwaIdtlYnRVnzoTZe4=;
        b=afJSSxaUmqxTbld0CG0Cmc1XCSL3TCUYAMC0amai8sGvPfQrY4V1l6eDMEg1c43z4h
         HtBz3PHNBAWKVqlgHIfYxMijMfzZq8wz68nB3hBo9Lyo9jr3wa8f9j+iuZSEW3qM+Q2x
         tFIytnUK0Fvq9rqcKVrActqMb4w6ukB5Oy3Rs=
In-Reply-To: <20100927184918.7fec30ac@lembas.zaitcev.lan>
Sender: hail-devel-owner@vger.kernel.org
List-ID: <hail-devel.vger.kernel.org>
Content-Type: text/plain; charset="us-ascii"; format="flowed"
To: Pete Zaitcev <zaitcev@redhat.com>
Cc: Project Hail List <hail-devel@vger.kernel.org>, Jim Meyering <jim@meyering.net>

On 09/27/2010 08:49 PM, Pete Zaitcev wrote:
> Premature optimization is the root of all evil.
>
> Use a sensible convention of not screwing with the argument, at the expense
> of extra strdup.
>
> Fortunately, all users are confined to Hail itself, even if huri_field_escape
> is exported.
>
> Signed-off-by: Pete Zaitcev<zaitcev@redhat.com>
>
> ---
>   include/hstor.h |    2 +-
>   lib/hstor.c     |   44 +++++++++++++++++++++++++++++---------------
>   lib/huri.c      |   10 +++++-----
>   3 files changed, 35 insertions(+), 21 deletions(-)

applied