From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jeff Garzik <jeff@garzik.org>
Subject: Re: [tabled patch 1/1] Add a test for hstor_keys
Date: Mon, 27 Sep 2010 22:49:46 -0400
Message-ID: <4CA157CA.1070808@garzik.org>
References: <20100927185240.31f3265e@lembas.zaitcev.lan>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Return-path: <hail-devel-owner@vger.kernel.org>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=gamma;
        h=domainkey-signature:received:received:sender:message-id:date:from
         :user-agent:mime-version:to:cc:subject:references:in-reply-to
         :content-type:content-transfer-encoding;
        bh=+tU/wx9ME4WlkDHFIzGqT5JDalXxhUIsITh5Q/ZEbW4=;
        b=mf0BriZl6xZiRR1aTD2ENkBEBuSh3VkIFv5W8CV0dNxhEF34TgNstrw5U4oMSSemx9
         MUJTJ0g9GPyFV+zEN7PF075izXcdAbRKFwftpqg1lYJ+C1wG4+RiyOAIngl5oQPUN5dU
         RP0xk2yI+xGs/Xz3kxwzJ/5X5G3YjU+3ojDKU=
In-Reply-To: <20100927185240.31f3265e@lembas.zaitcev.lan>
Sender: hail-devel-owner@vger.kernel.org
List-ID: <hail-devel.vger.kernel.org>
Content-Type: text/plain; charset="us-ascii"; format="flowed"
To: Pete Zaitcev <zaitcev@redhat.com>
Cc: Project Hail List <hail-devel@vger.kernel.org>

On 09/27/2010 08:52 PM, Pete Zaitcev wrote:
> Our current tests do not invoke hstor_keys at all, and so they did not catch
> a crash with double free in append_qparam.
>
> Add a very basic test which at least calls hstor_keys to verify that it
> does not crash right away. This test does not excercise complex modes
> such as S3 paging, but better this than nothing.
>
> Signed-off-by: Pete Zaitcev<zaitcev@redhat.com>
>
> ---
>   test/Makefile.am |    4 +
>   test/list-keys.c |  102 +++++++++++++++++++++++++++++++++++++++++++++
>   2 files changed, 105 insertions(+), 1 deletion(-)

applied..  FYI you forgot to update test/.gitignore.  Fixed.