From: Ben Greear <greearb@candelatech.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: RFC: Store premable and g-mode flags in ieee80211_tx_info
Date: Tue, 28 Sep 2010 12:01:14 -0700 [thread overview]
Message-ID: <4CA23B7A.7020602@candelatech.com> (raw)
In-Reply-To: <1285699998.32597.1.camel@jlt3.sipsolutions.net>
On 09/28/2010 11:53 AM, Johannes Berg wrote:
> On Tue, 2010-09-28 at 10:56 -0700, Ben Greear wrote:
>
>> Anyway, the reason is that the driver may not know the VIF (and
>> vif may be deleted) when calling the ieee80211_rts_duration, so it needs to be stored
>> in the tx_info structure.
>
> But the vif pointer in the tx_info structure is valid during the entire
> tx() call, why would you need to call rts_duration during TX status?
Err, I guess you are right. I was thinking it might retransmit sometime
later, but at least ath5k doesn't appear to do this.
I'll remove that part of the patch unless someone thinks of a reason
to keep it.
Thanks,
Ben
>
> johannes
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
next prev parent reply other threads:[~2010-09-28 19:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-28 17:25 RFC: Store premable and g-mode flags in ieee80211_tx_info Ben Greear
2010-09-28 17:48 ` Johannes Berg
2010-09-28 17:56 ` Ben Greear
2010-09-28 18:53 ` Johannes Berg
2010-09-28 19:01 ` Ben Greear [this message]
2010-09-28 19:11 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CA23B7A.7020602@candelatech.com \
--to=greearb@candelatech.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.