From: Avi Kivity <avi@redhat.com>
To: Sheng Yang <sheng@linux.intel.com>
Cc: Marcelo Tosatti <mtosatti@redhat.com>, kvm@vger.kernel.org
Subject: Re: [PATCH 1/3] KVM: Emulation MSI-X mask bits for assigned devices
Date: Wed, 29 Sep 2010 10:36:25 +0200 [thread overview]
Message-ID: <4CA2FA89.3010809@redhat.com> (raw)
In-Reply-To: <1285667052-24907-2-git-send-email-sheng@linux.intel.com>
On 09/28/2010 11:44 AM, Sheng Yang wrote:
> This patch enable per-vector mask for assigned devices using MSI-X.
>
> +
> struct kvm_assigned_msix_entry {
> __u32 assigned_dev_id;
> __u32 gsi;
> __u16 entry; /* The index of entry in the MSI-X table */
> - __u16 padding[3];
> + __u16 flags;
> + __u16 padding[2];
> };
>
Given that this field wasn't a flag field previously, we can't expect it
to be zero. So before we can check it, userspace needs to tell us that
is knows the field is not padding, but a flags field.
You can use KVM_ENABLE_CAP for that.
--
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.
next prev parent reply other threads:[~2010-09-29 8:36 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-28 9:44 [PATCH 0/3] Emulate MSI-X mask bits for assigned devices Sheng Yang
2010-09-28 9:44 ` [PATCH 1/3] KVM: Emulation " Sheng Yang
2010-09-28 13:36 ` Michael S. Tsirkin
2010-09-29 1:17 ` Sheng Yang
2010-09-30 16:25 ` Marcelo Tosatti
2010-09-29 8:36 ` Avi Kivity [this message]
2010-09-30 5:41 ` Sheng Yang
2010-10-03 13:03 ` Avi Kivity
2010-10-11 9:32 ` Sheng Yang
2010-09-30 16:18 ` Marcelo Tosatti
2010-10-11 9:49 ` Sheng Yang
2010-10-11 17:11 ` Marcelo Tosatti
2010-10-03 11:12 ` Michael S. Tsirkin
2010-10-11 9:28 ` Sheng Yang
2010-10-11 10:01 ` Michael S. Tsirkin
2010-10-12 6:49 ` Sheng Yang
2010-10-12 18:28 ` Michael S. Tsirkin
2010-10-13 1:03 ` Sheng Yang
2010-10-13 10:35 ` Michael S. Tsirkin
2010-10-12 18:30 ` Michael S. Tsirkin
2010-10-13 0:58 ` Sheng Yang
2010-10-13 12:03 ` Michael S. Tsirkin
2010-09-28 9:44 ` [PATCH 2/3] qemu-kvm: device assignment: Some clean up for MSI-X code Sheng Yang
2010-09-28 9:44 ` [PATCH 3/3] qemu-kvm: device assignment: emulate MSI-X mask bits Sheng Yang
2010-09-30 16:44 ` [PATCH 0/3] Emulate MSI-X mask bits for assigned devices Marcelo Tosatti
2010-10-11 9:34 ` Sheng Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CA2FA89.3010809@redhat.com \
--to=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=sheng@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.