From: Gerd Hoffmann <kraxel@redhat.com>
To: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>,
qemu-devel@nongnu.org, Michal Suchanek <hramrach@centrum.cz>
Subject: [Qemu-devel] Re: [PATCH] console: Avoid dereferencing NULL active_console
Date: Wed, 29 Sep 2010 10:44:37 +0200 [thread overview]
Message-ID: <4CA2FC75.9060305@redhat.com> (raw)
In-Reply-To: <1284988279-8900-1-git-send-email-stefanha@linux.vnet.ibm.com>
On 09/20/10 15:11, Stefan Hajnoczi wrote:
> The console_select() function does not check that active_console is
> non-NULL before dereferencing it. When invoked with qemu -nodefaults it
> is possible to hit this case.
>
> This patch checks that active_console is non-NULL before stashing away
> the old console dimensions in console_select().
Looks sane to me, simliar tests exist in other places.
Acked-by: Gerd Hoffmann <kraxel@redhat.com>
cheers,
Gerd
next prev parent reply other threads:[~2010-09-29 8:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-20 13:11 [Qemu-devel] [PATCH] console: Avoid dereferencing NULL active_console Stefan Hajnoczi
2010-09-29 8:44 ` Gerd Hoffmann [this message]
2010-09-30 16:55 ` Stefan Weil
2010-10-03 7:52 ` Blue Swirl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CA2FC75.9060305@redhat.com \
--to=kraxel@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=hramrach@centrum.cz \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.