All of lore.kernel.org
 help / color / mirror / Atom feed
From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH] phonesim: simulate Send USSD in sim app
Date: Wed, 29 Sep 2010 05:03:15 -0500	[thread overview]
Message-ID: <4CA30EE3.8000606@gmail.com> (raw)
In-Reply-To: <1285754259.3417.22.camel@aeonflux>

[-- Attachment #1: Type: text/plain, Size: 738 bytes --]

Hi Marcel,

On 09/29/2010 04:57 AM, Marcel Holtmann wrote:
> Hi Denis,
> 
>>> ---
>>>  src/default.xml        |   23 +++++++++-
>>>  src/qsimcommand.cpp    |    6 ++-
>>>  src/simapplication.cpp |  114 ++++++++++++++++++++++++++++++++++++++++++++++++
>>>  src/simapplication.h   |    2 +
>>>  4 files changed, 142 insertions(+), 3 deletions(-)
>>>  mode change 100644 => 100755 src/simapplication.cpp
> 
> what was wrong with the clear indication that this patch is messed up.
> 
> This patch comes from a stupid Windows system that tries to change every
> single mode to 0755. Please fix this.

Whoops, my fault totally missed this.  I wonder if there are git
settings that can warn about this...

Regards,
-Denis

  reply	other threads:[~2010-09-29 10:03 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-28 11:09 simulate Send USSD in sim app Jeevaka Badrappan
2010-09-28 11:09 ` [PATCH] phonesim: " Jeevaka Badrappan
2010-09-29  2:10   ` Denis Kenzior
2010-09-29  9:57     ` Marcel Holtmann
2010-09-29 10:03       ` Denis Kenzior [this message]
2010-09-29 10:10         ` Jeevaka.Badrappan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4CA30EE3.8000606@gmail.com \
    --to=denkenz@gmail.com \
    --cc=ofono@ofono.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.