From: Martin Schitter <ms@mur.at>
To: grub-devel@gnu.org
Subject: Re: [PATCH] segfault in grub-probe when spare or faulty disks are found
Date: Wed, 29 Sep 2010 14:16:07 +0200 [thread overview]
Message-ID: <4CA32E07.1070709@mur.at> (raw)
In-Reply-To: <4CA24F0B.904@gmail.com>
Am 2010-09-28 22:24, schrieb Vladimir 'φ-coder/phcoder' Serbinenko:
> I didn't respond to the patch because it's not correct: it only
> propagates the restriction instead of removing it. Thanks for reporting
> the issue. I'll fix it tomorrow (hopefully)
yes, there are more consequent ways to solve the problem.
my simple patch doesn't distinguish between all the special cases:
index == 0xffff: spare disk,
index == 0xfffe: faulty disk
index out of range (>= GRUB_RAID_MAX_DEVICES).
it makes a very simple test and ignores all affected devices in any
case. isn't that enough to prevent the segmentation fault?
it would be nice, if you could find a better workaround.
next prev parent reply other threads:[~2010-09-29 12:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-27 20:32 [PATCH] segfault in grub-probe when spare or faulty disks are found Martin Schitter
2010-09-28 20:24 ` Vladimir 'φ-coder/phcoder' Serbinenko
2010-09-29 12:16 ` Martin Schitter [this message]
2010-10-25 11:07 ` Martin Schitter
2010-10-25 11:11 ` Vladimir 'φ-coder/phcoder' Serbinenko
2010-10-26 8:58 ` Vladimir 'φ-coder/phcoder' Serbinenko
2010-10-26 15:29 ` Martin Schitter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CA32E07.1070709@mur.at \
--to=ms@mur.at \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.