From: Ben Greear <greearb@candelatech.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH] iw: Flush stdout when printing events.
Date: Wed, 29 Sep 2010 13:21:30 -0700 [thread overview]
Message-ID: <4CA39FCA.6000806@candelatech.com> (raw)
In-Reply-To: <1285743567.3756.1.camel@jlt3.sipsolutions.net>
On 09/28/2010 11:59 PM, Johannes Berg wrote:
> On Tue, 2010-09-28 at 17:30 -0700, greearb@candelatech.com wrote:
>
>> -#define PARSE_BEACON_CHAN(_attr, _chan) do { \
>> - r = parse_beacon_hint_chan(tb[_attr], \
>> - &_chan); \
>> - if (r) \
>> - return NL_SKIP; \
>> -} while (0)
>> +
>> +#define PARSE_BEACON_CHAN(_attr, _chan) do { \
>> + r = parse_beacon_hint_chan(tb[_attr], \
>> + &_chan); \
>> + if (r) { \
>> + fflush(stdout); \
>> + return NL_SKIP; \
>> + } \
>> + } while (0)
>> +
>
> Why does that need fflush() here? We'll eventually finish that line, no?
This returns from the print_event method, so I assume it should
flush. If it finishes the line, I'm not sure where.
Either way, thanks for taking the other change.
Thanks,
Ben
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
next prev parent reply other threads:[~2010-09-29 20:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-29 0:30 [PATCH] iw: Flush stdout when printing events greearb
2010-09-29 6:59 ` Johannes Berg
2010-09-29 20:21 ` Ben Greear [this message]
2010-09-29 20:29 ` Johannes Berg
2010-09-29 20:33 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CA39FCA.6000806@candelatech.com \
--to=greearb@candelatech.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.