All of lore.kernel.org
 help / color / mirror / Atom feed
From: Abraham Arce <x0066660@ti.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: "linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
	"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
	"Syed, Rafiuddin" <rafiuddin.syed@ti.com>
Subject: Re: [PATCH v6 7/8] OMAP4: Keyboard board support
Date: Thu, 30 Sep 2010 02:04:53 -0500	[thread overview]
Message-ID: <4CA43695.3030108@ti.com> (raw)
In-Reply-To: <20100930064055.GG5260@core.coreip.homeip.net>

Hi Dmitry,

Dmitry Torokhov wrote:
> HI Abraham,
> 
> On Thu, Sep 30, 2010 at 12:36:13AM -0500, Abraham Arce wrote:
>> From: Syed Rafiuddin <rafiuddin.syed@ti.com>
>>
>> Keyboard support for SDP OMAP4430
>>
> 
> I think this would benefit from "const" sprinkled on it.

You mean?

-static int sdp4430_keymap[] = {
+static const int sdp4430_keymap[] = {

> 
> BTW, I picked up patches 2, 3, 4, 5, 8 (all touching drivers/input).

Thanks!

Best Regards
Abraham

  reply	other threads:[~2010-09-30  7:04 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-30  5:36 [PATCH v6 7/8] OMAP4: Keyboard board support Abraham Arce
2010-09-30  6:40 ` Dmitry Torokhov
2010-09-30  7:04   ` Abraham Arce [this message]
2010-09-30  7:36     ` Dmitry Torokhov
2010-10-01 22:51   ` Tony Lindgren
2010-10-01 23:05     ` Kevin Hilman
2010-10-01 23:14       ` Tony Lindgren
2010-10-01 23:20         ` Abraham Arce
2010-10-01 23:22       ` Dmitry Torokhov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4CA43695.3030108@ti.com \
    --to=x0066660@ti.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=rafiuddin.syed@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.