Re: [PATCH] vim-7.2: remove quotes from CC in configure.in

[Thilo Fromm <t.fromm@dresearch.de>]

Hello Paul,

>> upstream: OE-only
>
> Please remove this again.

I will. Same thing as with the other patches: I learned the right place 
for this tag after this patch went out.

>> configure.in features quotes around some calls to $CC (i.e. it calls
>> "$CC"). CC is, however, not always just the compiler name. In OpenEmbedded
>> CC looks more like "arm-angstrom-linux-gnueabi-gcc -march=armv5te -mtune=arm926ej-s -mthumb-interwork -mno-thumb".
>>
[...]
>> configure: creating ./config.status
>> config.status: creating auto/config.mk
>> config.status: creating auto/config.h
>>
>> So the configure step had errors, but didn't report any in the return code.
>>
>> This patch removes the quotes around the CC variable in configure.in, which unbreaks the configure step.
>
> I have the same questions as before. Do you know if something similar is
> needed upstream? I think it is not OE only since other frameworks have
> similar values for `CC`.

Hmmm, do you think? I found this a way too tiny issue to report back 
upstream. But allright, I'll report it to the Vim developer's mailing 
list tomorrow, and refer to the e-mail thread in the upstream tag.

>> diff --git a/recipes/vim/files/configure.in_remove_CC_quotes.patch b/recipes/vim/files/configure.in_remove_CC_quotes.patch
>> new file mode 100644
>> index 0000000..db9fb07
>> --- /dev/null
>> +++ b/recipes/vim/files/configure.in_remove_CC_quotes.patch
>
> Please add the appropriate patch header.

I'm getting the idea now. Don't give up yet :)

>>
>>   addtask applypatch after do_unpack before do_patch
>
> Besides that I build tested your patch and it worked for
> `angstrom-2008.1`, `minimal-{eglibc,libc,uclibc}` and `MACHINE =
> "beagleboard"`.

It worked? Well, then your default minimal build includes X libraries. 
Target vim-7.2 fails in a clean build without X libraries, because the 
recipe is still broken. Another patch fixes this, it's already in the 
queue. Anyway, thanks for testing!

Regards,
Thilo

-- 
Dipl.-Ing (FH) Thilo Fromm, MSc., Embedded Systems Developer
DResearch Digital Media Systems GmbH
Otto-Schmirgal-Str. 3, D-10319 Berlin, Germany
Tel: +49 (30) 515 932 228   mailto:t.fromm@dresearch.de
Fax: +49 (30) 515 932 77    http://www.dresearch.de
Amtsgericht: Berlin Charlottenburg, HRB:54412
Ust.-IDNr. DE169013825; WEEE Reg.-Nr. DE 85995642
Geschäftsführer: Dr. M. Weber, W. Mögle