From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jeff Garzik <jeff@garzik.org>
Subject: Re: [PATCH hail] chunkd: don't leak an FS object iterator
Date: Thu, 30 Sep 2010 14:44:14 -0400
Message-ID: <4CA4DA7E.3040801@garzik.org>
References: <87aan0k249.fsf@meyering.net>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Return-path: <hail-devel-owner@vger.kernel.org>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=gamma;
        h=domainkey-signature:received:received:sender:message-id:date:from
         :user-agent:mime-version:to:cc:subject:references:in-reply-to
         :content-type:content-transfer-encoding;
        bh=kC2W0rHZ3TASGoXGg9XVop8b4Nyvjom1JInlnPX7ok4=;
        b=wpiG0IgmIKF4yc+hf6C7atiapGA5CpgV3KTBpjI/qTNPEd+T6sPwuBpiVOa3YKynyc
         b/e52a1tiM9Ap464Q2NIDF6dCqHNjAv2CcbH9/rChPSq5oSrjlg+WQccmalVdR2TLsby
         tfThLw6s0uNAgHb6/LpB3QESURuThk2lRn+B4=
In-Reply-To: <87aan0k249.fsf@meyering.net>
Sender: hail-devel-owner@vger.kernel.org
List-ID: <hail-devel.vger.kernel.org>
Content-Type: text/plain; charset="us-ascii"; format="flowed"
To: Jim Meyering <jim@meyering.net>
Cc: Project Hail <hail-devel@vger.kernel.org>, Pete Zaitcev <zaitcev@redhat.com>

On 09/29/2010 11:20 AM, Jim Meyering wrote:
>
> chk_list_objs called fs_list_objs_open without also calling
> fs_list_objs_close.
>
>   32,808 bytes in 1 blocks are definitely lost in loss record 413 of 419
>      at 0x4A0515D: malloc (vg_replace_malloc.c:195)
>      by 0x31BA8A26D0: __alloc_dir (opendir.c:184)
>      by 0x405619: fs_list_objs_open (be-fs.c:974)
>      by 0x40B202: chk_list_objs (selfcheck.c:41)
>      by 0x40B575: chk_dbscan (selfcheck.c:131)
>      by 0x40B628: chk_thread_scan (selfcheck.c:147)
>      by 0x40B757: chk_thread_command (selfcheck.c:179)
>      by 0x40B890: chk_thread_func (selfcheck.c:219)
>      by 0x31BC464E83: g_thread_create_proxy (gthread.c:1893)
>      by 0x31BB407760: start_thread (pthread_create.c:301)
>      by 0x31BA8E151C: clone (clone.S:115)

After seeing a few valgrind references from you, I'm curious... do you 
by chance happen to have a valgrind suppression file for openssl on Fedora?

I've been wanting to run valgrind on chunkd, but each time I attempt it, 
I -- and valgrind -- have been overwhelmed by openssl false positives. 
openssl, deep in its RAND_xxx functions, intentionally does crazy stuff 
like using random, uninitialized stack contents as RNG entropy.  Cute, 
but valgrind quite rightly complains loudly about it.

It's a topic I've been meaning to research, because I currently lack the 
valgrind-fu necessary to have an effective valgrind+chunkd session.

Thanks,

	Jeff