From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=56866 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1P1PeQ-0001ut-Ri
	for qemu-devel@nongnu.org; Thu, 30 Sep 2010 16:22:47 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <weil@mail.berlios.de>) id 1P1PeP-00076T-MO
	for qemu-devel@nongnu.org; Thu, 30 Sep 2010 16:22:46 -0400
Received: from moutng.kundenserver.de ([212.227.17.8]:62089)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <weil@mail.berlios.de>) id 1P1PeP-000765-8G
	for qemu-devel@nongnu.org; Thu, 30 Sep 2010 16:22:45 -0400
Message-ID: <4CA4F18A.4080005@mail.berlios.de>
Date: Thu, 30 Sep 2010 22:22:34 +0200
From: Stefan Weil <weil@mail.berlios.de>
MIME-Version: 1.0
References: <1285875019-14246-1-git-send-email-weil@mail.berlios.de>
	<AANLkTik5zH0-GUYMaW74OtSBZE0CsxwjTtSxpu045mHv@mail.gmail.com>
	<4CA4EB4A.6010400@mail.berlios.de>
	<AANLkTimZ0g8LyPFbkRxXDQfGr3R2uic7nu_CKJ46kvm9@mail.gmail.com>
In-Reply-To: <AANLkTimZ0g8LyPFbkRxXDQfGr3R2uic7nu_CKJ46kvm9@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH] ds1225y: Fix compiler errors in debug code
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: QEMU Developers <qemu-devel@nongnu.org>

Am 30.09.2010 22:09, schrieb Blue Swirl:
> On Thu, Sep 30, 2010 at 7:55 PM, Stefan Weil <weil@mail.berlios.de> wrote:
>> Am 30.09.2010 21:37, schrieb Blue Swirl:
>>>
>>> On Thu, Sep 30, 2010 at 7:30 PM, Stefan Weil<weil@mail.berlios.de> 
>>>  wrote:
>>>
>>>>
>>>> TARGET_FMT_lx is not allowed here, so use type casts to unsigned
>>>> (which should be large enough to hold typical nvram addresses).
>>>>
>>>
>>> The correct format is TARGET_FMT_plx.
>>>
>>
>>
>> addr is typically less than 8192 (size of nvram).
>>
>> TARGET_FMT_plx displays addr using 16 hex characters
>> when the target has 64 bit addresses. That's correct but
>> does not look pretty.
>>
>> Do you prefer TARGET_FMT_plx nevertheless?
>
> We could also introduce a new format which does not perform zero padding.

Like PRIxTPA (TPA = Target Physical Address)? That would allow devices
to print their addresses according to their needs with 1, 2, 4 or more
characters.

#if TARGET_PHYS_ADDR_BITS == 32
#define PRIxTPA PRIx32
#elif TARGET_PHYS_ADDR_BITS == 64
#define PRIxTPA PRIx64
#endif

If that's ok for everybody, I could provide a patch for targphys.h
and update the patch for ds1225y.c.