From: Heiko Schocher <heiko.schocher@invitel.hu>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 13/17] post/i2c: Add ability to ignore I2C devices
Date: Fri, 01 Oct 2010 08:29:19 +0200 [thread overview]
Message-ID: <4CA57FBF.7060501@invitel.hu> (raw)
In-Reply-To: <20100930172124.5360C134F56@gemini.denx.de>
Hello Wolfgang,
Wolfgang Denk wrote:
> Dear Peter Tyser,
>
> In message <1285851649.22004.5.camel@ptyser-laptop> you wrote:
>> Currently the POST code makes sure every entry in the white list is
>> found, but it also considers any unexpected devices found an error. Eg
>> you plug in a daughter card with an EEPROM on it that isn't listed in
>> I2C_ADDR_LIST, and the POST fails with:
>> I2C: addr 50 not expected
>
> Yes, and this is actually intentional.
>
>> As an alternative to this patch we could not treat unexpected devices as
>> an error, but you'd lose a small amount of POST coverage and
>> flexibility.
>
> No, we don't want to do this.
>
> So the IGNORE_LIST is intended for devices that may or may not be
> present, and neither state is considered an error?
>
>
>>>>> I2C_POST_ADDR_IGNORE_LIST
>>>> I was following the lead of the existing I2C_ADDR_LIST define. Agreed
>>>> it should be named differently. I'll go with CONFIG_SYS_POST_I2C_ADDRS
>>>> and CONFIG_SYS_POST_I2C_IGNORES unless someone else chimes in.
>>> Argh... I don't like identifiers that need half a line or more...
>> Agreed, but its hard when over half the name is the mandatory
>> CONFIG_SYS_POST_ prefix. Any suggestions?
>
> Omit that ?
:-(
... this is not only here a problem, this problem occurs *all* over
the code, because we have defined that we use CONFIG_SYS_ or CONFIG_
prefixes ... see README "Software Configuration" ...
and yes, this is a long fix prefix definition ... especially if
we want to add subsystem prefixes like I2C, POST, USB (which I think
is not a bad thing) ... then definelength will grow ...
bye,
Heiko
next prev parent reply other threads:[~2010-10-01 6:29 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-29 19:05 [U-Boot] [PATCH 01/17] XPedite5500 board support Peter Tyser
2010-09-29 19:05 ` [U-Boot] [PATCH 02/17] mpc8640: Update the io_sel fields for PCI Express Peter Tyser
2010-09-30 4:41 ` Kumar Gala
2010-09-30 14:54 ` Peter Tyser
2010-10-20 6:41 ` Kumar Gala
2010-09-29 19:05 ` [U-Boot] [PATCH 03/17] xes: Use common PCI initialization code Peter Tyser
2010-09-29 19:05 ` [U-Boot] [PATCH 04/17] pci: Add ability to re-enumerate PCI buses Peter Tyser
2010-10-20 6:45 ` Kumar Gala
2010-10-20 19:57 ` Wolfgang Denk
2010-10-21 5:31 ` Peter Tyser
2010-09-29 19:05 ` [U-Boot] [PATCH 05/17] ppc: Don't initialize write protected NOR flashes Peter Tyser
2010-10-20 6:46 ` Kumar Gala
2010-10-20 7:21 ` Stefan Roese
2010-10-20 19:58 ` Wolfgang Denk
2010-09-29 19:05 ` [U-Boot] [PATCH 06/17] xes: Consolidate checkboard() Peter Tyser
2010-09-29 19:05 ` [U-Boot] [PATCH 07/17] xes: Add board_flash_wp_on() Peter Tyser
2010-09-29 19:05 ` [U-Boot] [PATCH 08/17] xes: Make X-ES board names more generic Peter Tyser
2010-09-29 19:05 ` [U-Boot] [PATCH 09/17] xes: Add POST support for 8xxx boards Peter Tyser
2010-09-29 19:05 ` [U-Boot] [PATCH 10/17] post/i2c: General clean up Peter Tyser
2010-09-30 6:09 ` Heiko Schocher
2010-09-29 19:05 ` [U-Boot] [PATCH 11/17] post/i2c: Clean up detection logic Peter Tyser
2010-09-30 6:10 ` Heiko Schocher
2010-09-29 19:05 ` [U-Boot] [PATCH 12/17] post/i2c: Don't probe address 0 Peter Tyser
2010-09-30 6:10 ` Heiko Schocher
2010-09-29 19:05 ` [U-Boot] [PATCH 13/17] post/i2c: Add ability to ignore I2C devices Peter Tyser
2010-09-30 6:10 ` Heiko Schocher
2010-09-30 6:35 ` Peter Tyser
2010-09-30 6:50 ` Heiko Schocher
2010-09-30 7:44 ` Wolfgang Denk
2010-09-30 13:00 ` Peter Tyser
2010-09-30 17:21 ` Wolfgang Denk
2010-09-30 17:40 ` Peter Tyser
2010-09-30 17:54 ` Wolfgang Denk
2010-10-01 6:29 ` Heiko Schocher [this message]
2010-09-30 11:00 ` Sergei Shtylyov
2010-09-30 11:04 ` Reinhard Meyer
2010-09-30 14:38 ` Peter Tyser
2010-09-30 15:04 ` Sergei Shtylyov
2010-09-30 15:42 ` Peter Tyser
2010-09-30 16:36 ` Sergei Shtylyov
2010-09-29 19:05 ` [U-Boot] [PATCH 14/17] xes: Ignore XMC EEPROMs during I2C POST Peter Tyser
2010-09-29 19:05 ` [U-Boot] [PATCH 15/17] 86xx: Create common linker script Peter Tyser
2010-09-29 23:24 ` Timur Tabi
2010-09-30 0:54 ` Peter Tyser
2010-10-20 6:36 ` Kumar Gala
2010-09-29 19:05 ` [U-Boot] [PATCH 16/17] 86xx: Use gc-sections to reduce image size Peter Tyser
2010-10-20 6:36 ` Kumar Gala
2010-09-29 19:05 ` [U-Boot] [PATCH 17/17] 85xx: " Peter Tyser
2010-10-20 6:36 ` Kumar Gala
2010-10-04 22:11 ` [U-Boot] [PATCH 01/17] XPedite5500 board support Timur Tabi
2010-10-20 6:46 ` Kumar Gala
2010-10-21 5:29 ` Peter Tyser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CA57FBF.7060501@invitel.hu \
--to=heiko.schocher@invitel.hu \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.