From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Hellstrom <thellstrom@vmware.com>
Subject: Re: [PATCH] drm/ttm: Fix missing return
Date: Fri, 01 Oct 2010 12:14:28 +0200
Message-ID: <4CA5B484.2010002@vmware.com>
References: <1285920578-10101-1-git-send-email-thellstrom@vmware.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org>
Received: from smtp-outbound-2.vmware.com (smtp-outbound-2.vmware.com
	[65.115.85.73])
	by gabe.freedesktop.org (Postfix) with ESMTP id CA2FF9E762
	for <dri-devel@lists.freedesktop.org>;
	Fri,  1 Oct 2010 03:14:26 -0700 (PDT)
In-Reply-To: <1285920578-10101-1-git-send-email-thellstrom@vmware.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/dri-devel>,
	<mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/dri-devel>,
	<mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org
Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org
To: "airlied@redhat.com" <airlied@redhat.com>
Cc: Thomas Hellstrom <thellstrom@vmware.com>, "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>
List-Id: dri-devel@lists.freedesktop.org

Hmm. Forget this patch! I must have been extremely tired today. A new 
one coming up in a moment.

/Thomas


On 10/01/2010 10:09 AM, Thomas Hellstrom wrote:
> The commit "drm/ttm: Fix two race conditions"
> was missing a return statement in a very unlikely code path.
>
> Signed-off-by: Thomas Hellstrom<thellstrom@vmware.com>
> ---
>   drivers/gpu/drm/ttm/ttm_bo.c |    1 +
>   1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c
> index b98cb2c..d6000d7 100644
> --- a/drivers/gpu/drm/ttm/ttm_bo.c
> +++ b/drivers/gpu/drm/ttm/ttm_bo.c
> @@ -524,6 +524,7 @@ static int ttm_bo_cleanup_refs(struct ttm_buffer_object *bo, bool remove_all)
>   			atomic_set(&bo->reserved, 0);
>   			wake_up_all(&bo->event_queue);
>   			spin_unlock(&glob->lru_lock);
> +			return 0;
>   		}
>
>   		put_count = ttm_bo_del_from_lru(bo);
>