From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=51156 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1P1gZ3-00049D-Uk for qemu-devel@nongnu.org; Fri, 01 Oct 2010 10:26:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1P1gYj-0005PT-AJ for qemu-devel@nongnu.org; Fri, 01 Oct 2010 10:26:21 -0400 Received: from e6.ny.us.ibm.com ([32.97.182.146]:58280) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1P1gYj-0005PK-6a for qemu-devel@nongnu.org; Fri, 01 Oct 2010 10:26:01 -0400 Received: from d01relay07.pok.ibm.com (d01relay07.pok.ibm.com [9.56.227.147]) by e6.ny.us.ibm.com (8.14.4/8.13.1) with ESMTP id o91EQE7w031896 for ; Fri, 1 Oct 2010 10:26:14 -0400 Received: from d01av01.pok.ibm.com (d01av01.pok.ibm.com [9.56.224.215]) by d01relay07.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id o91EPvEo1360086 for ; Fri, 1 Oct 2010 10:25:58 -0400 Received: from d01av01.pok.ibm.com (loopback [127.0.0.1]) by d01av01.pok.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id o91EPvul007772 for ; Fri, 1 Oct 2010 10:25:57 -0400 Message-ID: <4CA5EF6F.5010500@linux.vnet.ibm.com> Date: Fri, 01 Oct 2010 09:25:51 -0500 From: Anthony Liguori MIME-Version: 1.0 References: <1285880180-29724-1-git-send-email-lcapitulino@redhat.com> <1285880180-29724-11-git-send-email-lcapitulino@redhat.com> <4CA5E29F.4030606@linux.vnet.ibm.com> <20101001104906.498b9cf6@doriath> In-Reply-To: <20101001104906.498b9cf6@doriath> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH 10/19] QMP: Introduce query commands dispatch table List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: qemu-devel@nongnu.org, armbru@redhat.com On 10/01/2010 08:49 AM, Luiz Capitulino wrote: > On Fri, 01 Oct 2010 08:31:11 -0500 > Anthony Liguori wrote: > > >> On 09/30/2010 03:56 PM, Luiz Capitulino wrote: >> >>> The new table is a copy of HMP's table, containing only QObject >>> handlers. >>> >>> In the near future HMP will be making QMP calls and then we will >>> be able to drop QObject handlers from HMP's table. >>> >>> >>>> From now on, QMP and HMP have different query command dispatch >>>> >>> tables. >>> >>> >> I like this series a lot and I think it's ready to merge. >> >> But I wonder, why have a separate qmp_query_cmds table? Why not just >> fold the query commands into qmp_cmds? >> > Yes, that will be done shortly, but in a different series. > Perfect :-) > I'm not doing it in this series because it's necessary to change the > signature of all those functions which would make this series too large and > harder to review. > > On a related note: I have more monitor patches in my queue. I'm building > and testing them right now. I'm planning to send a pull request of all > pending monitor patches later today. So, if you prefer, you can wait for > that pull request instead of merging this series alone. > Yes, let's do that. This whole series: Reviewed-by: Anthony Liguori Regards, Anthony Liguori > It will generate some noise on the list though, as I think it's good practice > to resend patches in a pull request to the list. >