All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mr Dash Four <mr.dash.four@googlemail.com>
To: Jozsef Kadlecsik <kadlec@blackhole.kfki.hu>
Cc: netfilter@vger.kernel.org
Subject: Re: ipporthash, ipportiphash, ipportnethash problems
Date: Sat, 02 Oct 2010 11:36:43 +0100	[thread overview]
Message-ID: <4CA70B3B.90001@googlemail.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1010012302530.19869@blackhole.kfki.hu>


> Thanks for the complete description - I have just released ipset 4.4 which 
> fixes this nasty bug.
>   
No worries - I was surprised to find it as ipporthash in particular 
should have been widely used in practice. As for ipportiphash and 
ipportnethash - there were recently included in the distribution due to 
another bug I found when compiling xtables (even though ipportiphash and 
ipportnethash were compiled the .ko files were never included in the 
final release making it impossible to use these two construct types).

A couple of questions and ideas for future releases:

1. Normally I used to get ipset as part of the xtables source. Is that 
still the case or do I have to download the ipset source and compile it 
separately to get the latest changes you made?
2. Related to that question - I used to get the xtables .src.rpm from 
which to compile the code and make an installation rpm. I don't seem to 
be able to do that any longer as all fedora repos are too slow to update 
the latest changes. Do you have a link from which I could get the latest 
changes in ipset/xtables in src.rpm which allows me to build an 
installation rpm. The reason I am asking this is because I am building 
an update images on all my machines (using kickstart) and need the 
installation rpms with the latest changes you made. Compiling this from 
source won't be possible as there is now way I could install this as 
part of the image-building process.

I think you mentioned that in future releases the restrictions on all 
*hash constructs (with regards to using /16 - B class - IP addresses) 
will be removed. Could you confirm that is still the case?

Would it be possible to include a new construct - IP,port,IP,port 
(without IP address restriction) - and how difficult is this to implement?

Similar question - would it be possible to include protocol (either by 
name or its number) as part of all available constructs for matching? 
The reason for this is that, as it stands, in order for me to match, 
say, "IP,port" hosts form my personal VPN I need to use two separate 
sets - one for UDP and one for TCP and I also to create two separate 
statements for iptables (one for tcp and one for udp), which is a bit of 
a waste and not very easy to administer. It would be nice if I could use 
"IP,protocol", "port,protocol", "IP,port,protocol", 
"IP,port,IP,protocol", "IP,port,IP/cidr,protocol" and so forth.

  reply	other threads:[~2010-10-02 10:36 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-30 22:03 ipporthash, ipportiphash, ipportnethash problems Mr Dash Four
2010-10-01  7:18 ` Jozsef Kadlecsik
2010-10-01 11:22   ` Mr Dash Four
2010-10-01 21:05     ` Jozsef Kadlecsik
2010-10-02 10:36       ` Mr Dash Four [this message]
2010-10-02 19:21         ` Jozsef Kadlecsik
2010-10-02 20:08           ` Mr Dash Four
2010-10-02 20:40             ` Jan Engelhardt
2010-10-02 20:54               ` Mr Dash Four
2010-10-02 21:06                 ` Jan Engelhardt
2010-10-03 18:57             ` Jozsef Kadlecsik
2010-10-03 22:02               ` Mr Dash Four
2010-10-02 20:35           ` Mr Dash Four
2010-10-03 19:13             ` Jozsef Kadlecsik
2010-10-03 22:04               ` Mr Dash Four
2010-10-04  9:36                 ` Jozsef Kadlecsik
2010-10-06 14:23                   ` Mr Dash Four
2010-10-06 14:37                     ` Mike Wright
2010-10-06 15:26                       ` Mr Dash Four
2010-10-06 19:57                     ` Jozsef Kadlecsik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4CA70B3B.90001@googlemail.com \
    --to=mr.dash.four@googlemail.com \
    --cc=kadlec@blackhole.kfki.hu \
    --cc=netfilter@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.