From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=56869 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1P25Vr-0001Jy-EC
	for qemu-devel@nongnu.org; Sat, 02 Oct 2010 13:04:44 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <clarkjc@runbox.com>) id 1P25Vq-00082X-4Q
	for qemu-devel@nongnu.org; Sat, 02 Oct 2010 13:04:43 -0400
Received: from aibo.runbox.com ([87.238.52.70]:56760)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <clarkjc@runbox.com>) id 1P25Vp-00082L-Ty
	for qemu-devel@nongnu.org; Sat, 02 Oct 2010 13:04:42 -0400
Message-ID: <4CA76624.2040505@runbox.com>
Date: Sat, 02 Oct 2010 13:04:36 -0400
From: John Clark <clarkjc@runbox.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] Minor MMU fixes for PowerPC 40x emulation
References: <4CA6C549.9090801@runbox.com>
	<6569D071-7989-4426-9E30-7B5E80C79027@suse.de>
	<4CA762B1.7060505@runbox.com>
	<0E0E4F59-0325-44C5-9330-EB48B8A8C46F@suse.de>
In-Reply-To: <0E0E4F59-0325-44C5-9330-EB48B8A8C46F@suse.de>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alexander Graf <agraf@suse.de>
Cc: QEMU Developers <qemu-devel@nongnu.org>

>>>>
>>>> -target_ulong helper_4xx_tlbre_hi (target_ulong entry)
>>>> +target_ulong helper_4xx_tlbre_lo (target_ulong entry)
>>>
>>> Huh?
>>
>> To summarize, 'tlbre' has two forms: one to retrieve the high bits of
>> a TLB entry (TLBHI), and one to retrieve the low bits (TLBLO) of a TLB
>> entry.  This code had the TLBLO form returning the bits corresponding
>> to TLBHI and vice versa, hence the name change.  You can verify this
>> if you like with this IBM PowerPC 405 core user manual on page 362:
> 
> Well the thing that strikes me as weird is mostly that you're changing a function name, but no callers to it. So is this function never used? Or was tlbre_lo defined before already and is now defined twice?

You'll see that helper_4xx_tlbre_hi changes to helper_4xx_tlbre_lo and
that helper_4xx_tlbre_lo changes to helper_4xx_tlbre_hi, so
helper_4xx_tlbre_lo is not multiply defined.

> 
> PS: Please use the "reply to all" function of your mailer. Others might be interested in the reply too :).
> 

Yes, I realized my mistake a few minutes after sending the previous
reply and corrected it.

- John